]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
ath79: meraki-mr18: fix MAC address offset after NVMEM switch 23486/head
authorLech Perczak <lech.perczak@gmail.com>
Sat, 23 May 2026 00:29:10 +0000 (02:29 +0200)
committerRobert Marko <robimarko@gmail.com>
Sat, 23 May 2026 16:42:22 +0000 (18:42 +0200)
The following commit: 27a673916c35 ("ath79: mr18: use nvmem for MACs")
switched MR18 to use NVMEM subsystem for setting MAC addresses, however
it missed the offset in use. Previously 102 (decimal) was used, but in
device tree 0x102 was used, but the correct value is 0x66.

This was found while reviewing code for Z1 port, which shares the MAC
address source.
Replace the offset with the correct one of 0x66.

Fixes: 27a673916c35 ("ath79: mr18: use nvmem for MACs")
Signed-off-by: Lech Perczak <lech.perczak@gmail.com>
Link: https://github.com/openwrt/openwrt/pull/23486
Signed-off-by: Robert Marko <robimarko@gmail.com>
target/linux/ath79/dts/qca9557_meraki_mr18.dts

index 3fa4e57456b852e6a07c24a45823c1da19129664..ee0db7c63014ca5dc18fe571f382772552ed092f 100644 (file)
                                                #address-cells = <1>;
                                                #size-cells = <1>;
 
-                                               macaddr_board_102: macaddr@102 {
+                                               macaddr_board_66: macaddr@66 {
                                                        compatible = "mac-base";
-                                                       reg = <0x102 0x6>;
+                                                       reg = <0x66 0x6>;
                                                        #nvmem-cell-cells = <1>;
                                                };
                                        };
                compatible = "pci168c,0033";
                reg = <0x0000 0 0 0 0>;
                qca,no-eeprom;
-               nvmem-cells = <&macaddr_board_102 2>;
+               nvmem-cells = <&macaddr_board_66 2>;
                nvmem-cell-names = "mac-address";
        };
 };
                compatible = "pci168c,0033";
                reg = <0x0000 0 0 0 0>;
                qca,no-eeprom;
-               nvmem-cells = <&macaddr_board_102 3>;
+               nvmem-cells = <&macaddr_board_66 3>;
                nvmem-cell-names = "mac-address";
        };
 };
        pll-data = <0xa6000000 0xa0000101 0x80001313>;
        phy-handle = <&phy>;
 
-       nvmem-cells = <&macaddr_board_102 0>;
+       nvmem-cells = <&macaddr_board_66 0>;
        nvmem-cell-names = "mac-address";
 
        gmac-config {
        status = "okay";
        qca,no-eeprom;
 
-       nvmem-cells = <&macaddr_board_102 1>;
+       nvmem-cells = <&macaddr_board_66 1>;
        nvmem-cell-names = "mac-address";
 };