]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Silence gcc-10-fanalyzer false positive
authorMark Andrews <marka@isc.org>
Tue, 18 May 2021 05:19:28 +0000 (15:19 +1000)
committerMark Andrews <marka@isc.org>
Tue, 18 May 2021 05:48:32 +0000 (15:48 +1000)
Add REQUIRE(type == dns_rdatatype_nsec3 || firstp != NULL); so
that dereferences of *firstp is not flagged as a NULL pointer
dereference.

(cherry picked from commit 683ad6e4bd12315ace3703d56ba0f0a3b1ad660f)

lib/dns/rbtdb.c

index 9d27a1519f9abe88e154e95e343ece4f3e757936..3ee18766cdb0c6100a070b5f25726c391bc46be2 100644 (file)
@@ -3874,6 +3874,7 @@ previous_closest_nsec(dns_rdatatype_t type, rbtdb_search_t *search,
        isc_result_t result;
 
        REQUIRE(nodep != NULL && *nodep == NULL);
+       REQUIRE(type == dns_rdatatype_nsec3 || firstp != NULL);
 
        if (type == dns_rdatatype_nsec3) {
                result = dns_rbtnodechain_prev(&search->chain, NULL, NULL);