2553. [bug] Reference leak on DNSSEC validation errors. [RT #19291]

diff --git a/CHANGES b/CHANGES
index a0742e8f1285e8fb4f50c87c1eb0c6253a9e762d..4916f0e35fb0f1248c4cc2027eb4d2fc58f51f15 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,5 @@
+2553.  [bug]           Reference leak on DNSSEC validation errors. [RT #19291]
+
 2552.  [bug]           zero-no-soa-ttl-cache was not being honoured.
                        [RT #19340]
 

diff --git a/lib/dns/validator.c b/lib/dns/validator.c
index 4e8080e14440328a09b67cb7b424a53e1b5dd16a..f7e0630cd7873a315e3b44a687e29e3767d2de9a 100644 (file)
--- a/lib/dns/validator.c
+++ b/lib/dns/validator.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: validator.c,v 1.119.18.46 2009/01/19 00:36:27 marka Exp $ */
+/* $Id: validator.c,v 1.119.18.47 2009/02/15 23:39:53 marka Exp $ */
 
 /*! \file */
 
@@ -1606,6 +1606,7 @@ dlv_validatezonekey(dns_validator_t *val) {
                                break;
                }
                if (result != ISC_R_SUCCESS) {
+                       dns_rdataset_disassociate(&trdataset);
                        validator_log(val, ISC_LOG_DEBUG(3),
                                      "no DNSKEY matching DLV");
                        continue;
@@ -1947,6 +1948,7 @@ validatezonekey(dns_validator_t *val) {
                                break;
                }
                if (result != ISC_R_SUCCESS) {
+                       dns_rdataset_disassociate(&trdataset);
                        validator_log(val, ISC_LOG_DEBUG(3),
                                      "no DNSKEY matching DS");
                        continue;