]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: tas2781: fix unused-const-variable warning
authorArnd Bergmann <arnd@arndb.de>
Mon, 13 Apr 2026 07:00:45 +0000 (09:00 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 13 Apr 2026 16:42:14 +0000 (17:42 +0100)
When both CONFIG_OF and CONFIG_ACPI are disabled, the ID table is not
referenced any more:

sound/soc/codecs/tas2781-i2c.c:102:35: error: 'tasdevice_id' defined but not used [-Werror=unused-const-variable=]
  102 | static const struct i2c_device_id tasdevice_id[] = {
      |                                   ^~~~~~~~~~~~

Remove the #ifdef checks and just include the ID tables unconditionally
to get a clean build in all configurations. The code already uses
IS_ENABLED() checks for both to benefit from dead code elimination
and the ID tables are small enough that they can just be included
all the time.

Fixes: 9a52d1b7cb4a ("ASoC: tas2781: Explicit association of Device, Device Name, and Device ID")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20260413070059.3828364-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tas2781-i2c.c

index c593f9da0c5b9bc166dcf75b04c58d5ca2d819bd..8af30f4d68da7cec927b6801019f7f54f7c929bd 100644 (file)
@@ -122,7 +122,6 @@ static const struct i2c_device_id tasdevice_id[] = {
        {}
 };
 
-#ifdef CONFIG_OF
 static const struct of_device_id tasdevice_of_match[] = {
        { .compatible = "ti,tas2020", .data = &tasdevice_id[TAS2020] },
        { .compatible = "ti,tas2118", .data = &tasdevice_id[TAS2118] },
@@ -146,7 +145,6 @@ static const struct of_device_id tasdevice_of_match[] = {
        {},
 };
 MODULE_DEVICE_TABLE(of, tasdevice_of_match);
-#endif
 
 /**
  * tas2781_digital_getvol - get the volum control
@@ -2083,7 +2081,6 @@ static void tasdevice_i2c_remove(struct i2c_client *client)
        tasdevice_remove(tas_priv);
 }
 
-#ifdef CONFIG_ACPI
 static const struct acpi_device_id tasdevice_acpi_match[] = {
        { "TXNW2020", (kernel_ulong_t)&tasdevice_id[TAS2020] },
        { "TXNW2118", (kernel_ulong_t)&tasdevice_id[TAS2118] },
@@ -2108,15 +2105,12 @@ static const struct acpi_device_id tasdevice_acpi_match[] = {
 };
 
 MODULE_DEVICE_TABLE(acpi, tasdevice_acpi_match);
-#endif
 
 static struct i2c_driver tasdevice_i2c_driver = {
        .driver = {
                .name = "tasdev-codec",
-               .of_match_table = of_match_ptr(tasdevice_of_match),
-#ifdef CONFIG_ACPI
-               .acpi_match_table = ACPI_PTR(tasdevice_acpi_match),
-#endif
+               .of_match_table = tasdevice_of_match,
+               .acpi_match_table = tasdevice_acpi_match,
        },
        .probe  = tasdevice_i2c_probe,
        .remove = tasdevice_i2c_remove,