]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3: winbindd: assign rangenum member after NULL check
authorShaleen Bathla <shaleen.bathla@oracle.com>
Wed, 21 Feb 2024 13:25:28 +0000 (18:55 +0530)
committerNoel Power <npower@samba.org>
Thu, 22 Feb 2024 10:57:38 +0000 (10:57 +0000)
if we are doing NULL check for range, then we should assign its member
after the NULL check.

Signed-off-by: Shaleen Bathla <shaleen.bathla@oracle.com>
Reviewed-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Noel Power <npower@samba.org>
Autobuild-User(master): Noel Power <npower@samba.org>
Autobuild-Date(master): Thu Feb 22 10:57:38 UTC 2024 on atb-devel-224

source3/winbindd/idmap_autorid_tdb.c

index 6c76764076a5cc0b86ae20be8bfbb4569fdd7231..68c4d2f3355102ae406d73da4a42aa19581d0ffa 100644 (file)
@@ -97,7 +97,6 @@ static NTSTATUS idmap_autorid_addrange_action(struct db_context *db,
        ctx = (struct idmap_autorid_addrange_ctx *)private_data;
        range = ctx->range;
        acquire = ctx->acquire;
-       requested_rangenum = range->rangenum;
 
        if (db == NULL) {
                DEBUG(3, ("Invalid database argument: NULL\n"));
@@ -109,6 +108,8 @@ static NTSTATUS idmap_autorid_addrange_action(struct db_context *db,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
+       requested_rangenum = range->rangenum;
+
        DEBUG(10, ("Adding new range for domain %s "
                   "(domain_range_index=%"PRIu32")\n",
                   range->domsid, range->domain_range_index));