mpls: add missing unregister_netdevice_notifier to mpls_init

[ Upstream commit 99600f79b28c83c68bae199a3d8e95049a758308 ]

If mpls_init() fails after registering mpls_dev_notifier, it never
gets removed. Add the missing unregister_netdevice_notifier() call to
the error handling path.

Fixes: 5be2062e3080 ("mpls: Handle error of rtnl_register_module().")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/7c55363c4f743d19e2306204a134407c90a69bbb.1773228081.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 3373b6b34dc7df2286ec546efc18b101122f1b44..719dabb76ea2180ab8cdbdfa29667ae3c71fcb29 100644 (file)
--- a/net/mpls/af_mpls.c
+++ b/net/mpls/af_mpls.c
@@ -2774,6 +2774,7 @@ out_unregister_rtnl:
 out_unregister_rtnl_af:
        rtnl_af_unregister(&mpls_af_ops);
        dev_remove_pack(&mpls_packet_type);
+       unregister_netdevice_notifier(&mpls_dev_notifier);
 out_unregister_pernet:
        unregister_pernet_subsys(&mpls_net_ops);
        goto out;