]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainAttachDeviceDiskLive: Remove 'disk' variable
authorPeter Krempa <pkrempa@redhat.com>
Thu, 5 Mar 2026 14:10:54 +0000 (15:10 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 10 Mar 2026 13:47:26 +0000 (14:47 +0100)
Remove the extra temporary variable to make the changes in the next
patch more obvious.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_hotplug.c

index 966e746f2bca60006f4a1b948226f19e5839e1d0..8652b143b6421b973c512de028e7769e6d014229 100644 (file)
@@ -1134,20 +1134,19 @@ qemuDomainAttachDeviceDiskLive(virQEMUDriver *driver,
                                virDomainObj *vm,
                                virDomainDeviceDef *dev)
 {
-    virDomainDiskDef *disk = dev->data.disk;
     virDomainDiskDef *orig_disk = NULL;
 
     /* this API overloads media change semantics on disk hotplug
      * for devices supporting media changes */
-    if ((disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ||
-         disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) &&
-        (orig_disk = virDomainDiskByTarget(vm->def, disk->dst))) {
+    if ((dev->data.disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ||
+         dev->data.disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) &&
+        (orig_disk = virDomainDiskByTarget(vm->def, dev->data.disk->dst))) {
         if (qemuDomainChangeEjectableMedia(driver, vm, orig_disk,
-                                           disk->src, false) < 0)
+                                           dev->data.disk->src, false) < 0)
             return -1;
 
-        disk->src = NULL;
-        virDomainDiskDefFree(disk);
+        dev->data.disk->src = NULL;
+        virDomainDiskDefFree(dev->data.disk);
         return 0;
     }