]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
phy: qcom: edp: Fix AUX_CFG8 programming for DP mode
authorYongxing Mou <yongxing.mou@oss.qualcomm.com>
Mon, 27 Apr 2026 06:35:22 +0000 (14:35 +0800)
committerVinod Koul <vkoul@kernel.org>
Sun, 3 May 2026 17:04:47 +0000 (22:34 +0530)
AUX_CFG8 depends on whether the PHY is operating in eDP or DP mode, not
the selected swing/pre-emphasis table. All supported platforms already
have the proper tables, so remove the unnecessary check.

Cc: stable@vger.kernel.org
Fixes: 6078b8ce070c ("phy: qcom: edp: Add set_mode op for configuring eDP/DP submode")
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Yongxing Mou <yongxing.mou@oss.qualcomm.com>
Link: https://patch.msgid.link/20260427-edp_phy-v5-4-3bb876824475@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-edp.c

index 3e613b3740327282bf10c3c280510c1c26e5f34b..3a848f18a8d6083157db8d54482232872e03e7c2 100644 (file)
@@ -325,12 +325,7 @@ static int qcom_edp_phy_init(struct phy *phy)
               DP_PHY_PD_CTL_PLL_PWRDN | DP_PHY_PD_CTL_DP_CLAMP_EN,
               edp->edp + DP_PHY_PD_CTL);
 
-       /*
-        * TODO: Re-work the conditions around setting the cfg8 value
-        * when more information becomes available about why this is
-        * even needed.
-        */
-       if (edp->cfg->dp_swing_pre_emph_cfg && !edp->is_edp)
+       if (!edp->is_edp)
                aux_cfg[8] = 0xb7;
 
        writel(0xfc, edp->edp + DP_PHY_MODE);