]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-event: make event_source_time_prioq_reshuffle() accept all event source type
authorYu Watanabe <watanabe.yu+github@gmail.com>
Mon, 14 Jun 2021 17:03:02 +0000 (02:03 +0900)
committerThe Plumber <50238977+systemd-rhel-bot@users.noreply.github.com>
Wed, 21 Jul 2021 12:15:58 +0000 (14:15 +0200)
But it does nothing for an event source which is neither a timer nor
ratelimited.

(cherry picked from commit 5c08c7ab23dbf02aaf4e4bbae8e08a195da230a4)

Related: #1968528

src/libsystemd/sd-event/sd-event.c

index f675c09d840fae50b656f6517131cf08bf2e6fb9..ae46392901aec54a07451b0a9d358685f95112ef 100644 (file)
@@ -954,14 +954,15 @@ static void event_source_time_prioq_reshuffle(sd_event_source *s) {
         assert(s);
 
         /* Called whenever the event source's timer ordering properties changed, i.e. time, accuracy,
-         * pending, enable state. Makes sure the two prioq's are ordered properly again. */
+         * pending, enable state, and ratelimiting state. Makes sure the two prioq's are ordered
+         * properly again. */
 
         if (s->ratelimited)
                 d = &s->event->monotonic;
-        else {
-                assert(EVENT_SOURCE_IS_TIME(s->type));
+        else if (EVENT_SOURCE_IS_TIME(s->type))
                 assert_se(d = event_get_clock_data(s->event, s->type));
-        }
+        else
+                return; /* no-op for an event source which is neither a timer nor ratelimited. */
 
         prioq_reshuffle(d->earliest, s, &s->earliest_index);
         prioq_reshuffle(d->latest, s, &s->latest_index);