dns_qpkey_toname failed to reset name correctly

This could lead to a mismatch between name->length and the rest
of the name structure.

diff --git a/lib/dns/qp.c b/lib/dns/qp.c
index dff011ba6684b9ebd5f21baf77a06a7f2922fea4..686c3561f5f35eb9203490ac26678d2dabaad629 100644 (file)
--- a/lib/dns/qp.c
+++ b/lib/dns/qp.c
@@ -259,13 +259,12 @@ dns_qpkey_toname(const dns_qpkey_t key, size_t keylen, dns_name_t *name) {
        REQUIRE(name->buffer != NULL);
        REQUIRE(name->offsets != NULL);
 
+       dns_name_reset(name);
+
        if (keylen == 0) {
-               dns_name_reset(name);
                return;
        }
 
-       isc_buffer_clear(name->buffer);
-
        /* Scan the key looking for label boundaries */
        for (offset = 0; offset <= keylen; offset++) {
                INSIST(key[offset] >= SHIFT_NOBYTE &&