]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
staging: rtl8723bs: remove redundant check on status
authorColin Ian King <colin.i.king@gmail.com>
Thu, 29 Jan 2026 16:10:58 +0000 (16:10 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 7 Feb 2026 12:30:34 +0000 (13:30 +0100)
The check on status can be removed because all previous
assignments on status are followed by a goto statement that
bypasses the status check. This minor issue was detected with
Coverity Scan static analysis. Remove the redundant check and
some empty lines.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://patch.msgid.link/20260129161058.197372-1-colin.i.king@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

index 884fcce50d9caaf972364f609ef557922ddacf5f..606fc67261552f5094cdacca38664caa5dc17f6a 100644 (file)
@@ -1265,19 +1265,12 @@ unsigned int OnAssocReq(struct adapter *padapter, union recv_frame *precv_frame)
        else
                pstat->flags &= ~WLAN_STA_SHORT_PREAMBLE;
 
-
-
-       if (status != WLAN_STATUS_SUCCESS)
-               goto OnAssocReqFail;
-
        /* TODO: identify_proprietary_vendor_ie(); */
        /*  Realtek proprietary IE */
        /*  identify if this is Broadcom sta */
        /*  identify if this is ralink sta */
        /*  Customer proprietary IE */
 
-
-
        /* get a unique AID */
        if (pstat->aid == 0) {
                for (pstat->aid = 1; pstat->aid <= NUM_STA; pstat->aid++)