]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
usb: typec: intel_pmc_mux: Zero initialize num_ports in pmc_usb_probe()
authorNathan Chancellor <nathan@kernel.org>
Wed, 6 May 2026 06:05:54 +0000 (14:05 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 22 May 2026 09:34:36 +0000 (11:34 +0200)
Clang warns (or errors with CONFIG_WERROR=y / W=e):

  drivers/usb/typec/mux/intel_pmc_mux.c:740:3: error: variable 'num_ports' is uninitialized when used here [-Werror,-Wuninitialized]
    740 |                 num_ports++;
        |                 ^~~~~~~~~

This should have been initialized to zero. Do so now to clean up the
warning and ensure num_ports does not use uninitialized memory.

Fixes: 8bdb0b3830ea ("usb: typec: intel_pmc_mux: combine kzalloc + kcalloc")
Reported-by: kernelci.org bot <bot@kernelci.org>
Closes: https://lore.kernel.org/177793914437.2560.9287713196857718000@997d03828cfd/
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://patch.msgid.link/20260506-typec-intel_pmc_mux-fix-uninit-num_ports-v1-1-929b128a32e9@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/mux/intel_pmc_mux.c

index e22b070a140f9aa96b449926bbf1280f069294e7..219a32da13480866d9d6a4b2e19cbcd22934e54f 100644 (file)
@@ -732,7 +732,7 @@ static int pmc_usb_probe(struct platform_device *pdev)
 {
        struct fwnode_handle *fwnode = NULL;
        struct pmc_usb *pmc;
-       u8 num_ports;
+       u8 num_ports = 0;
        int i = 0;
        int ret;