]> git.ipfire.org Git - thirdparty/gnutls.git/commitdiff
write_oid_and_params: moved nullity check of params earlier
authorNikos Mavrogiannopoulos <nmav@gnutls.org>
Mon, 13 Aug 2018 18:19:55 +0000 (20:19 +0200)
committerNikos Mavrogiannopoulos <nmav@gnutls.org>
Mon, 13 Aug 2018 19:50:32 +0000 (21:50 +0200)
Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
lib/x509/mpi.c

index 2c301d321d7f580427d96b172416597101329c8a..20a64690a3d1c8b80cd87c1f9d2fbf21d9712c13 100644 (file)
@@ -284,10 +284,14 @@ static int write_oid_and_params(ASN1_TYPE dst, const char *dst_name, const char
        int result;
        char name[128];
 
+       if (params == NULL) {
+               gnutls_assert();
+               return GNUTLS_E_INVALID_REQUEST;
+       }
+
        _gnutls_str_cpy(name, sizeof(name), dst_name);
        _gnutls_str_cat(name, sizeof(name), ".algorithm");
 
-
        /* write the OID.
         */
        result = asn1_write_value(dst, name, oid, 1);
@@ -305,11 +309,6 @@ static int write_oid_and_params(ASN1_TYPE dst, const char *dst_name, const char
        else if (params->pk == GNUTLS_PK_RSA_PSS) {
                gnutls_datum_t tmp = { NULL, 0 };
 
-               if (params == NULL) {
-                       gnutls_assert();
-                       return GNUTLS_E_INVALID_REQUEST;
-               }
-
                result = _gnutls_x509_write_rsa_pss_params(params, &tmp);
                if (result < 0)
                        return gnutls_assert_val(result);