]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/backlight: Short circuit intel_dp_aux_supports_hdr_backlight
authorSuraj Kandpal <suraj.kandpal@intel.com>
Mon, 2 Mar 2026 04:06:10 +0000 (09:36 +0530)
committerSuraj Kandpal <suraj.kandpal@intel.com>
Tue, 3 Mar 2026 02:58:54 +0000 (08:28 +0530)
intel_dp_aux_supports_hdr_backlight() prints debug message for
intel HDR backlight version. This is fine when dealing with eDP 1.4b
and lower. When we are talking about eDP 1.5 it causes confusion in
logs since we need to use VESA AUX backlight functions but this
print causes confusion as to which path code take.
Short circuit this function with a eDP version check. Make sure this
is only called if eDP <= 1.4b

Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: Arun R Murthy <arun.r.murthy@intel.com>
Link: https://patch.msgid.link/20260302040613.3324049-6-suraj.kandpal@intel.com
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c

index 8d7c5089fb1c4c68943b0935a4d4d6440254f7a8..9d9872e9daa4d4b69af0231231c33d1243d02af0 100644 (file)
@@ -692,8 +692,8 @@ int intel_dp_aux_init_backlight_funcs(struct intel_connector *connector)
         * Also there is a chance some VBTs may advertise false Intel backlight support even if the
         * TCON DPCD says otherwise. This means we keep VESA interface as fallback in that case.
         */
-       if (try_intel_interface && intel_dp_aux_supports_hdr_backlight(connector) &&
-           intel_dp->edp_dpcd[0] <= DP_EDP_14b) {
+       if (try_intel_interface && intel_dp->edp_dpcd[0] <= DP_EDP_14b &&
+           intel_dp_aux_supports_hdr_backlight(connector)) {
                drm_dbg_kms(dev, "[CONNECTOR:%d:%s] Using Intel proprietary eDP backlight controls\n",
                            connector->base.base.id, connector->base.name);
                panel->backlight.funcs = &intel_dp_hdr_bl_funcs;