u-boot-tools: drop the hardlink workaround in do_compile

This workaround initially considered a host running git < v2.14, which
does not look realistic if we consider the fairly recent distros in
SANITY_TESTED_DISTROS.

Even in older build machines/distros, one can use buildtools to provide git:

$ ./x86_64-buildtools-extended-nativesdk-standalone-5.0.sh
(...)
$ which git
(...)/buildtools/sysroots/x86_64-pokysdk-linux/usr/bin/git
$ git --version
git version 2.44.0

It is harmless, but still a bit outdated, so remove it.

[RP: the earliest git version on our test builders is ~2.33 so no distros
we currently support would run into this]

Signed-off-by: João Marcos Costa <joaomarcos.costa@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/recipes-bsp/u-boot/u-boot-tools.inc b/meta/recipes-bsp/u-boot/u-boot-tools.inc
index 4e4f7fa092dd1c7191cfb17dff81a2e71eb061c6..738d843591e917b759c7bb1e5cea7a22f846af99 100644 (file)
--- a/meta/recipes-bsp/u-boot/u-boot-tools.inc
+++ b/meta/recipes-bsp/u-boot/u-boot-tools.inc
@@ -27,21 +27,6 @@ SED_CONFIG_EFI:aarch64 = ''
 SED_CONFIG_EFI:loongarch64 = ''
 
 do_compile () {
-       # Yes, this is crazy. If you build on a system with git < 2.14 from scratch, the tree will
-       # be marked as "dirty" and the version will include "-dirty", leading to a reproducibility problem.
-       # The issue is the inode count for Licnses/README changing due to do_populate_lic hardlinking a
-       # copy of the file. We avoid this by ensuring the index is updated with a "git diff" before the
-       # u-boot machinery tries to determine the version.
-       #
-       # build$ ../git/scripts/setlocalversion ../git
-       # ""
-       # build$ ln ../git/
-       # build$ ln ../git/README ../foo
-       # build$ ../git/scripts/setlocalversion ../git
-       # ""-dirty
-       # (i.e. creating a hardlink dirties the index)
-       cd ${S}; git diff; cd ${B}
-
        oe_runmake -C ${S} tools-only_defconfig O=${B}
 
        # Disable CONFIG_CMD_LICENSE, license.h is not used by tools and