]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
serial: qcom-geni: fix UART_RX_PAR_EN bit position
authorPrasanna S <prasanna.s@oss.qualcomm.com>
Tue, 28 Apr 2026 04:26:13 +0000 (09:56 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 11 May 2026 15:02:45 +0000 (17:02 +0200)
UART_RX_PAR_EN is incorrectly defined as bit 3, which triggers false
framing errors (S_GP_IRQ_1_EN) and causes received data to be dropped
when parity is enabled and the parity bit is 0.

Define UART_RX_PAR_EN as bit 4 of the SE_UART_RX_TRANS_CFG register, as
specified in the reference manual.

Fixes: c4f528795d1a ("tty: serial: msm_geni_serial: Add serial driver support for GENI based QUP")
Cc: stable <stable@kernel.org>
Signed-off-by: Prasanna S <prasanna.s@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://patch.msgid.link/20260428-serial-bit-correct-v1-1-9131ad5b97d8@oss.qualcomm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c

index b365dd5da3cb799c4ec241724310c23d6bf7e16a..5139a9d21b2b272eaaaf3152d4b2d2dd5acdb5ac 100644 (file)
@@ -50,7 +50,7 @@
 #define TX_STOP_BIT_LEN_2              2
 
 /* SE_UART_RX_TRANS_CFG */
-#define UART_RX_PAR_EN                 BIT(3)
+#define UART_RX_PAR_EN                 BIT(4)
 
 /* SE_UART_RX_WORD_LEN */
 #define RX_WORD_LEN_MASK               GENMASK(9, 0)