Make sure to detach injection points for re-attaching

The new test for enabling data checksums with concurrent CREATE
DATABASE calls use the same injection points as a previous test
but accidentally missed detaching the injection point first.

Fix by detaching the injection point in the PG_TEST_EXTRA SKIP
block to make it can be reused.  Pointed out by buildfarm member
porpoise which failed with:

    die: error running SQL: 'psql:<stdin>:1:
	     ERROR: injection point "datachecksumsworker-fake-temptable-wait"
		        already defined'

Backpatch to v19 where online checksums were introduced.

Author: Daniel Gustafsson <daniel@yesql.se>
Reported-by: Buildfarm member porpoise
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/28CF6FD9-E1C4-4C04-8270-E3305AC46171@yesql.se
Backpatch-through: 19

diff --git a/src/test/modules/test_checksums/t/005_injection.pl b/src/test/modules/test_checksums/t/005_injection.pl
index 34cd47e6c81be2db0daaa2f679e5520849f8d214..2387e4399babed88523bcef5b4c4f020a87c4307 100644 (file)
--- a/src/test/modules/test_checksums/t/005_injection.pl
+++ b/src/test/modules/test_checksums/t/005_injection.pl
@@ -74,6 +74,9 @@ SKIP:
                "SELECT injection_points_attach('datachecksumsworker-fake-temptable-wait', 'notice');"
        );
        enable_data_checksums($node, wait => 'on');
+       $node->safe_psql('postgres',
+               "SELECT injection_points_detach('datachecksumsworker-fake-temptable-wait');"
+       );
 }
 
 # ---------------------------------------------------------------------------