Workaround compiler bug that optimizes setting .free_pools

The .free_pools bitfield would not be set on some levels of
optimizations - workaround the compiler bug by reordering the setting
the .freepools in the initializer.

diff --git a/lib/dns/message.c b/lib/dns/message.c
index 7f8ffc76d1466e5513fe98217df4ef6498d5c7fa..5ec09c6f7da303da418ba9990ed1643ae4e54f8a 100644 (file)
--- a/lib/dns/message.c
+++ b/lib/dns/message.c
@@ -725,13 +725,13 @@ dns_message_create(isc_mem_t *mctx, isc_mempool_t *namepool,
                .magic = DNS_MESSAGE_MAGIC,
                .namepool = namepool,
                .rdspool = rdspool,
+               .free_pools = (namepool == NULL && rdspool == NULL),
        };
 
        isc_mem_attach(mctx, &msg->mctx);
 
-       if (namepool == NULL && rdspool == NULL) {
+       if (msg->free_pools) {
                dns_message_createpools(mctx, &msg->namepool, &msg->rdspool);
-               msg->free_pools = true;
        }
 
        msginit(msg);