]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Change log level when doing rekey
authorMatthijs Mekking <matthijs@isc.org>
Fri, 14 Oct 2022 14:38:25 +0000 (16:38 +0200)
committerMatthijs Mekking <matthijs@isc.org>
Tue, 18 Oct 2022 14:31:01 +0000 (16:31 +0200)
This log happens when BIND checks the parental-agents if the DS has
been published. But if you don't have parental-agents set up, the list
of keys to check will be empty and the result will be ISC_R_NOTFOUND.
This is not an error, so change the log level to debug in this case.

(cherry picked from commit a1d57fc8cb8f0e234bed89eedbae727bb56b4b90)

lib/dns/zone.c

index cd4db58eaf13cabd39ccc9bcf25f212440511143..4b20a057ad8ffa62a6fdc01d70da830cc9cd8130 100644 (file)
@@ -21453,13 +21453,15 @@ zone_rekey(dns_zone_t *zone) {
                result = dns_zone_getdnsseckeys(zone, db, ver, now,
                                                &zone->checkds_ok);
 
-               if (result != ISC_R_SUCCESS) {
-                       dnssec_log(zone, ISC_LOG_ERROR,
+               if (result == ISC_R_SUCCESS) {
+                       zone_checkds(zone);
+               } else {
+                       dnssec_log(zone,
+                                  (result == ISC_R_NOTFOUND) ? ISC_LOG_DEBUG(1)
+                                                             : ISC_LOG_ERROR,
                                   "zone_rekey:dns_zone_getdnsseckeys failed: "
                                   "%s",
                                   isc_result_totext(result));
-               } else {
-                       zone_checkds(zone);
                }
 
                if (result == ISC_R_SUCCESS || result == ISC_R_NOTFOUND) {