Add trampoline around iocompletionport_createthreads()

On Windows, the iocompletionport_createthreads() didn't use
isc_thread_create() to create new threads for processing IO, but just a
simple CreateThread() function that completely circumvent the
isc_trampoline mechanism to initialize global isc_tid_v.  This lead to
segmentation fault in isc_hp API because '-1' isn't valid index to the
hazard pointer array.

This commit changes the iocompletionport_createthreads() to use
isc_thread_create() instead of CreateThread() to properly initialize
isc_tid_v.

diff --git a/lib/isc/win32/socket.c b/lib/isc/win32/socket.c
index 89649641021409e64659a78e3e09118627754007..cf101189f8ac3db7c5e5a355747801c64a96894f 100644 (file)
--- a/lib/isc/win32/socket.c
+++ b/lib/isc/win32/socket.c
@@ -337,7 +337,6 @@ struct isc_socketmgr {
        HANDLE hIoCompletionPort;
        int maxIOCPThreads;
        HANDLE hIOCPThreads[MAX_IOCPTHREADS];
-       DWORD dwIOCPThreadIds[MAX_IOCPTHREADS];
        size_t maxudp;
 
        /*
@@ -500,15 +499,8 @@ iocompletionport_createthreads(int total_threads, isc_socketmgr_t *manager) {
         * We need at least one
         */
        for (i = 0; i < total_threads; i++) {
-               manager->hIOCPThreads[i] =
-                       CreateThread(NULL, 0, SocketIoThread, manager, 0,
-                                    &manager->dwIOCPThreadIds[i]);
-               if (manager->hIOCPThreads[i] == NULL) {
-                       errval = GetLastError();
-                       strerror_r(errval, strbuf, sizeof(strbuf));
-                       FATAL_ERROR(__FILE__, __LINE__,
-                                   "Can't create IOCP thread: %s", strbuf);
-               }
+               isc_thread_create(SocketIoThread, manager,
+                                 &manager->hIOCPThreads[i]);
        }
 }