]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ASoC: rt1320: fix the warning 'rae_fw' from request_firmware() not released
authorShuming Fan <shumingf@realtek.com>
Tue, 14 Apr 2026 07:14:41 +0000 (15:14 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 14 Apr 2026 11:13:53 +0000 (12:13 +0100)
New smatch warnings:
sound/soc/codecs/rt1320-sdw.c:1575 rt1320_rae_load() warn: 'rae_fw' from
request_firmware() not released on lines: 1575.

Fixes: 22937af75abb ("ASoC: rt1320: support RAE parameters loading")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Closes: https://lore.kernel.org/r/202604111548.EL450PMb-lkp@intel.com/
Signed-off-by: Shuming Fan <shumingf@realtek.com>
Link: https://patch.msgid.link/20260414071441.1524039-1-shumingf@realtek.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1320-sdw.c

index b0aeeab26bd99b5bf82f475d95ab15bdacbcf6c4..192faa431b5e9cd4d7f2d755c52e17020bb03cbf 100644 (file)
@@ -1498,6 +1498,7 @@ static int rt1320_rae_load(struct rt1320_sdw_priv *rt1320)
                }
                if (!retry && !(value & 0x40)) {
                        dev_err(dev, "%s: RAE is not ready to load\n", __func__);
+                       release_firmware(rae_fw);
                        return -ETIMEDOUT;
                }