3072. [bug] dns_dns64_aaaaok() potential NULL pointer dereference.

                        [RT #20256]

diff --git a/CHANGES b/CHANGES
index d5b2e88d26b6c10764e94017bad5d3610f43bdfd..6b29cd232ea72a8e8435d2bb7236a5b9dccc2a07 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+3072.  [bug]           dns_dns64_aaaaok() potential NULL pointer dereference.
+                       [RT #20256]
+
 3071.  [bug]           has_nsec could be used unintialised in
                        update.c:next_active. [RT #20256]
 

diff --git a/lib/dns/dns64.c b/lib/dns/dns64.c
index dad7658c9718219a07caa7d72ddfffbd01f45c22..0c35f561cd6aecc3c283d0cc7fd692882719a85a 100644 (file)
--- a/lib/dns/dns64.c
+++ b/lib/dns/dns64.c
@@ -14,7 +14,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dns64.c,v 1.6 2010/12/09 04:59:09 marka Exp $ */
+/* $Id: dns64.c,v 1.7 2011/03/11 13:02:33 marka Exp $ */
 
 #include <config.h>
 
@@ -253,6 +253,8 @@ dns_dns64_aaaaok(const dns_dns64_t *dns64, const isc_netaddr_t *reqaddr,
                 */
                if (dns64->excluded == NULL) {
                        answer = ISC_TRUE;
+                       if (aaaaok == NULL)
+                               goto done;
                        for (i = 0; i < aaaaoklen; i++)
                                aaaaok[i] = ISC_TRUE;
                        goto done;