]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Don't honour single read per client isc_nm_read() call in the TLSDNS
authorOndřej Surý <ondrej@isc.org>
Wed, 11 Jan 2023 09:17:55 +0000 (10:17 +0100)
committerOndřej Surý <ondrej@isc.org>
Wed, 11 Jan 2023 09:17:55 +0000 (10:17 +0100)
This reverts commit f17f5e831be6d07cc7476048444befbf1e06d5b6 that made
following change:

> The TLSDNS transport was not honouring the single read callback for
> TLSDNS client.  It would call the read callbacks repeatedly in case the
> single TLS read would result in multiple DNS messages in the decoded
> buffer.

Turns out that this change broke XoT, so we are reverting the change
until we figure out a proper fix that will keep the design promise and
not break XoT at the same time.

lib/isc/netmgr/tlsdns.c

index 177dadd601700c425c61bf992bfa0d10c2fb693e..19da3353e3c106f4de4b6cc0945879ff21548026 100644 (file)
@@ -1120,10 +1120,6 @@ tls_cycle_input(isc_nmsocket_t *sock) {
                                goto failure;
                        }
 
-                       if (atomic_load(&sock->client)) {
-                               break;
-                       }
-
                        if (pending == 0) {
                                break;
                        }