]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
fixup! When compiling for fuzzing, ensure the pseudo random number seed is non-zero.
authorOndřej Surý <ondrej@sury.org>
Wed, 28 Nov 2018 21:49:42 +0000 (22:49 +0100)
committerStephen Morris <stephen@isc.org>
Fri, 30 Nov 2018 11:21:55 +0000 (11:21 +0000)
lib/isc/random.c

index 0c1930d980ca57ddefd8db030f4013738d45906a..4be9292408be6c42e449742274bb4eb29e64ec13 100644 (file)
@@ -79,19 +79,17 @@ static isc_once_t isc_random_once = ISC_ONCE_INIT;
 
 static void
 isc_random_initialize(void) {
+       int useed[4] = {0,0,0,1};
 #if FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION
        /*
         * Set a constant seed to help in problem reproduction should fuzzing
         * find a crash or a hang.  The seed array must be non-zero else
         * xoshiro128starstar will generate an infinite series of zeroes.
         */
-       memset(seed, 0, sizeof(seed));
-       seed[0] = 1;
 #else
-       int useed[4] = {0,0,0,0};
        isc_entropy_get(useed, sizeof(useed));
-       memcpy(seed, useed, sizeof(seed));
 #endif
+       memcpy(seed, useed, sizeof(seed));
 }
 
 uint8_t