Don't print trace messages about null updates.

diff --git a/proto/bgp/packets.c b/proto/bgp/packets.c
index 0d9b702a97a8d903c71f95dc0403e373c90c7fb2..407d059b853f9c9c64cb8eba9f311a651e2420e0 100644 (file)
--- a/proto/bgp/packets.c
+++ b/proto/bgp/packets.c
@@ -82,7 +82,6 @@ bgp_create_update(struct bgp_conn *conn, byte *buf)
   int r_size = 0;
   int a_size = 0;
 
-  BGP_TRACE(D_PACKETS, "Sending UPDATE");
   w = buf+2;
   if ((buck = p->withdraw_bucket) && !EMPTY_LIST(buck->prefixes))
     {
@@ -118,7 +117,13 @@ bgp_create_update(struct bgp_conn *conn, byte *buf)
       put_u16(w, 0);
       w += 2;
     }
-  return (wd_size || r_size) ? w : NULL;
+  if (wd_size || r_size)
+    {
+      BGP_TRACE(D_PACKETS, "Sending UPDATE");
+      return w;
+    }
+  else
+    return NULL;
 }
 
 #else          /* IPv6 version */
@@ -136,7 +141,6 @@ bgp_create_update(struct bgp_conn *conn, byte *buf)
   eattr *nh;
   neighbor *n;
 
-  BGP_TRACE(D_PACKETS, "Sending UPDATE");
   put_u16(buf, 0);
   w = buf+4;
 
@@ -213,7 +217,13 @@ bgp_create_update(struct bgp_conn *conn, byte *buf)
   size = w - (buf+4);
   put_u16(buf+2, size);
   lp_flush(bgp_linpool);
-  return size ? w : NULL;
+  if (size)
+    {
+      BGP_TRACE(D_PACKETS, "Sending UPDATE");
+      return w;
+    }
+  else
+    return NULL;
 }
 
 #endif