methodpool: Improve method already seen error message

The current error message is confusing, this improves it to explain the problem
and the possible ways to resolve it.

[YOCTO #2530]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/lib/bb/methodpool.py b/lib/bb/methodpool.py
index 1485b1357d8341bc87eeed421d6354c3e1d2dbdf..c5aae9bc093f670574e0b84cedfac12fed3050cb 100644 (file)
--- a/lib/bb/methodpool.py
+++ b/lib/bb/methodpool.py
@@ -52,7 +52,7 @@ def insert_method(modulename, code, fn):
         if name in ['None', 'False']:
             continue
         elif name in _parsed_fns and not _parsed_fns[name] == modulename:
-            error( "Error Method already seen: %s in' %s' now in '%s'" % (name, _parsed_fns[name], modulename))
+            error("The function %s defined in %s was already declared in %s. BitBake has a global python function namespace so shared functions should be declared in a common include file rather than being duplicated, or if the functions are different, please use different function names." % (name, modulename, _parsed_fns[name]))
         else:
             _parsed_fns[name] = modulename