]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: refactor halbtc8723b1ant_CoexTableWithType() to remove duplication
authorBera Yüzlü <b9788213@gmail.com>
Thu, 26 Feb 2026 13:02:53 +0000 (16:02 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Mar 2026 16:05:52 +0000 (17:05 +0100)
Replace the verbose switch-case block with a constant 2D array lookup.
This makes the function much more concise and easier to read without
changing the underlying behavior.

Signed-off-by: Bera Yüzlü <b9788213@gmail.com>
Link: https://patch.msgid.link/20260226130253.2145-1-b9788213@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c

index 1af101ba97525d108b08fd83b31449443a954933..b3e34f97cfc6b523b79fd08162b130407c444b64 100644 (file)
@@ -684,52 +684,22 @@ static void halbtc8723b1ant_CoexTableWithType(
        struct btc_coexist *pBtCoexist, bool bForceExec, u8 type
 )
 {
+       static const u32 table[8][2] = {
+               {0x55555555, 0x55555555},
+               {0x55555555, 0x5a5a5a5a},
+               {0x5a5a5a5a, 0x5a5a5a5a},
+               {0xaaaa5555, 0xaaaa5a5a},
+               {0x55555555, 0xaaaa5a5a},
+               {0x5a5a5a5a, 0xaaaa5a5a},
+               {0x55555555, 0xaaaaaaaa},
+               {0xaaaaaaaa, 0xaaaaaaaa}
+       };
+
        pCoexSta->nCoexTableType = type;
 
-       switch (type) {
-       case 0:
-               halbtc8723b1ant_CoexTable(
-                       pBtCoexist, bForceExec, 0x55555555, 0x55555555, 0xffffff, 0x3
-               );
-               break;
-       case 1:
-               halbtc8723b1ant_CoexTable(
-                       pBtCoexist, bForceExec, 0x55555555, 0x5a5a5a5a, 0xffffff, 0x3
-               );
-               break;
-       case 2:
-               halbtc8723b1ant_CoexTable(
-                       pBtCoexist, bForceExec, 0x5a5a5a5a, 0x5a5a5a5a, 0xffffff, 0x3
-               );
-               break;
-       case 3:
-               halbtc8723b1ant_CoexTable(
-                       pBtCoexist, bForceExec, 0xaaaa5555, 0xaaaa5a5a, 0xffffff, 0x3
-               );
-               break;
-       case 4:
-               halbtc8723b1ant_CoexTable(
-                       pBtCoexist, bForceExec, 0x55555555, 0xaaaa5a5a, 0xffffff, 0x3
-               );
-               break;
-       case 5:
-               halbtc8723b1ant_CoexTable(
-                       pBtCoexist, bForceExec, 0x5a5a5a5a, 0xaaaa5a5a, 0xffffff, 0x3
-               );
-               break;
-       case 6:
-               halbtc8723b1ant_CoexTable(
-                       pBtCoexist, bForceExec, 0x55555555, 0xaaaaaaaa, 0xffffff, 0x3
-               );
-               break;
-       case 7:
-               halbtc8723b1ant_CoexTable(
-                       pBtCoexist, bForceExec, 0xaaaaaaaa, 0xaaaaaaaa, 0xffffff, 0x3
-               );
-               break;
-       default:
-               break;
-       }
+       if (type < 8)
+               halbtc8723b1ant_CoexTable(pBtCoexist, bForceExec, table[type][0],
+                                         table[type][1], 0xffffff, 0x3);
 }
 
 static void halbtc8723b1ant_SetFwIgnoreWlanAct(