[#3046] added comments

diff --git a/src/bin/dhcp6/tests/fqdn_unittest.cc b/src/bin/dhcp6/tests/fqdn_unittest.cc
index 2b2d7819fbf76e27b6858894ad202f70564df5aa..c10c3497572336ad2a609c41ded342dffae2aa87 100644 (file)
--- a/src/bin/dhcp6/tests/fqdn_unittest.cc
+++ b/src/bin/dhcp6/tests/fqdn_unittest.cc
@@ -129,6 +129,9 @@ public:
                                               D2ClientConfig::RCM_NEVER);
         subnet_->setDdnsGeneratedPrefix("myhost");
         subnet_->setDdnsQualifyingSuffix("example.com");
+        // In V6 the dot (".") can, and equally can not be specified in the
+        // "hostname-char-set" because the FQDN is split before any character
+        // is replaced and then is put back together.
         subnet_->setHostnameCharSet("[^A-Za-z0-9.-]");
         subnet_->setHostnameCharReplacement("x");
         subnet_->setDdnsConflictResolutionMode("check-with-dhcid");

diff --git a/src/lib/dhcpsrv/tests/d2_client_unittest.cc b/src/lib/dhcpsrv/tests/d2_client_unittest.cc
index bbfad172f10abcc4fb936fecadd78cba267dcbae..ded39278b8049ed4d98c865c0b698ebb5569e444 100644 (file)
--- a/src/lib/dhcpsrv/tests/d2_client_unittest.cc
+++ b/src/lib/dhcpsrv/tests/d2_client_unittest.cc
@@ -1086,6 +1086,11 @@ TEST_F(D2ClientMgrParamsTest, sanitizeFqdnV4) {
     subnet_->setDdnsReplaceClientNameMode(D2ClientConfig::RCM_NEVER);
     subnet_->setDdnsGeneratedPrefix("prefix");
     subnet_->setDdnsQualifyingSuffix("suffix.com");
+    // In V4 the dot (".") can, and equally can not be specified in the
+    // "hostname-char-set" because the FQDN is split before any character
+    // is replaced and then is put back together. However it does have an
+    // effect on the hostname option 12 (DHO_HOST_NAME), but this test is
+    // only checking the FQDN option.
     subnet_->setHostnameCharSet("[^A-Za-z0-9.-]");
     subnet_->setHostnameCharReplacement("x");
 
@@ -1169,6 +1174,9 @@ TEST_F(D2ClientMgrParamsTest, sanitizeFqdnV6) {
     subnet_->setDdnsReplaceClientNameMode(D2ClientConfig::RCM_NEVER);
     subnet_->setDdnsGeneratedPrefix("prefix");
     subnet_->setDdnsQualifyingSuffix("suffix.com");
+    // In V6 the dot (".") can, and equally can not be specified in the
+    // "hostname-char-set" because the FQDN is split before any character
+    // is replaced and then is put back together.
     subnet_->setHostnameCharSet("[^A-Za-z0-9.-]");
     subnet_->setHostnameCharReplacement("x");