]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Reduce struct isc__nm_uvreq size from 1560 to 560 bytes
authorOndřej Surý <ondrej@isc.org>
Tue, 12 Sep 2023 07:10:41 +0000 (09:10 +0200)
committerOndřej Surý <ondrej@isc.org>
Wed, 22 Jan 2025 13:12:38 +0000 (14:12 +0100)
The uv_req union member of struct isc__nm_uvreq contained libuv request
types that we don't use.  Turns out that uv_getnameinfo_t is 1000 bytes
big and unnecessarily enlarged the whole structure.  Remove all the
unused members from the uv_req union.

lib/isc/netmgr/netmgr-int.h

index a99153a8f2311fc0148cc65f1a6c19d39acbfe03..3ee138405cefd7decc313dc491e146ec0e2b36ff 100644 (file)
@@ -391,16 +391,11 @@ struct isc__nm_uvreq {
        int connect_tries;     /* connect retries */
 
        union {
-               uv_handle_t handle;
                uv_req_t req;
-               uv_getaddrinfo_t getaddrinfo;
-               uv_getnameinfo_t getnameinfo;
-               uv_shutdown_t shutdown;
+               uv_handle_t handle;
                uv_write_t write;
                uv_connect_t connect;
                uv_udp_send_t udp_send;
-               uv_fs_t fs;
-               uv_work_t work;
        } uv_req;
        ISC_LINK(isc__nm_uvreq_t) link;
 };