]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ACPI: button: Eliminate redundant conditional statement
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 1 Jun 2026 17:00:47 +0000 (19:00 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 1 Jun 2026 17:17:49 +0000 (19:17 +0200)
Simplify do_update initialization in acpi_lid_notify_state() by
assigning the value of the condition it depends on directly to it.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/10868292.nUPlyArG6x@rafael.j.wysocki
drivers/acpi/button.c

index fcb2eed823c15d9e2f78477ee1cf19c5a83a04d0..236eb025bb0dcb45be2977028947d0bb83ff022a 100644 (file)
@@ -217,12 +217,8 @@ static void acpi_lid_notify_state(struct acpi_button *button, bool state)
         * So "last_time" is only updated after a timeout or an actual
         * switch.
         */
-       if (lid_init_state != ACPI_BUTTON_LID_INIT_IGNORE ||
-           button->last_state != state)
-               do_update = true;
-       else
-               do_update = false;
-
+       do_update = lid_init_state != ACPI_BUTTON_LID_INIT_IGNORE ||
+                       button->last_state != state;
        next_report = ktime_add(button->last_time,
                                ms_to_ktime(lid_report_interval));
        if (button->last_state == state &&