]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
vfs_ceph_new: remove double-cleanup in closedir
authorShweta Sodani <ssodani@redhat.com>
Mon, 6 Apr 2026 05:53:32 +0000 (11:23 +0530)
committerAnoop C S <anoopcs@samba.org>
Tue, 21 Apr 2026 22:18:42 +0000 (22:18 +0000)
vfs_ceph_release_fh() was called explicitly then again via the FSP
extension destructor triggered by vfs_ceph_remove_fh(). Drop the
explicit call and let the destructor handle cleanup.

Signed-off-by: Shweta Sodani <ssodani@redhat.com>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Tue Apr 21 22:18:42 UTC 2026 on atb-devel-224

source3/modules/vfs_ceph_new.c

index c2e33ca524362ac7437d165152b96268f8d0f6eb..b5657e572ec82a9c1af526379c3bde70943c7f97 100644 (file)
@@ -2678,7 +2678,6 @@ static int vfs_ceph_closedir(struct vfs_handle_struct *handle, DIR *dirp)
        START_PROFILE_X(SNUM(handle->conn), syscall_closedir);
        DBG_DEBUG("[CEPH] closedir: dirp=%p\n", dirp);
        result = vfs_ceph_ll_releasedir(handle, cfh);
-       vfs_ceph_release_fh(cfh);
        vfs_ceph_remove_fh(handle, cfh->fsp);
        DBG_DEBUG("[CEPH] closedir: dirp=%p result=%d\n", dirp, result);
        END_PROFILE_X(syscall_closedir);