silence punned messages

diff --git a/bin/dnssec/dnssec-signzone.c b/bin/dnssec/dnssec-signzone.c
index a06ef6533e2df0128636578fb2b946a502d21cd7..ed0038eb6585633c8cf4f06f3a07fd776f812553 100644 (file)
--- a/bin/dnssec/dnssec-signzone.c
+++ b/bin/dnssec/dnssec-signzone.c
@@ -17,7 +17,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dnssec-signzone.c,v 1.173 2004/01/14 02:06:48 marka Exp $ */
+/* $Id: dnssec-signzone.c,v 1.174 2004/02/03 00:59:02 marka Exp $ */
 
 #include <config.h>
 
@@ -1104,7 +1104,7 @@ assignwork(isc_task_t *task, isc_task_t *worker) {
 
        sevent->node = node;
        sevent->fname = fname;
-       isc_task_send(worker, (isc_event_t **)&sevent);
+       isc_task_send(worker, (isc_event_t **) (void*) &sevent);
        assigned++;
 }
 
@@ -1160,7 +1160,7 @@ sign(isc_task_t *task, isc_event_t *event) {
                fatal("failed to allocate event\n");
        wevent->node = node;
        wevent->fname = fname;
-       isc_task_send(master, (isc_event_t **)&wevent);
+       isc_task_send(master, (isc_event_t **) (void*) &wevent);
 }
 
 /*

diff --git a/bin/dnssec/dnssectool.c b/bin/dnssec/dnssectool.c
index 8f80c745e14f3235fa1fe5d74fd4d8a8c3c72a62..07b05934921960dc905f29c2f47f74a50cc5f244 100644 (file)
--- a/bin/dnssec/dnssectool.c
+++ b/bin/dnssec/dnssectool.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dnssectool.c,v 1.38 2003/09/30 05:56:00 marka Exp $ */
+/* $Id: dnssectool.c,v 1.39 2004/02/03 00:59:02 marka Exp $ */
 
 #include <config.h>
 
@@ -290,15 +290,15 @@ strtotime(const char *str, isc_int64_t now, isc_int64_t base) {
 
 dns_rdataclass_t
 strtoclass(const char *str) {
-       isc_consttextregion_t r;
+       isc_textregion_t r;
        dns_rdataclass_t rdclass;
        isc_result_t ret;
 
        if (str == NULL)
                return dns_rdataclass_in;
-       r.base = str;
+       DE_CONST(str, r.base);
        r.length = strlen(str);
-       ret = dns_rdataclass_fromtext(&rdclass, (isc_textregion_t *)&r);
+       ret = dns_rdataclass_fromtext(&rdclass, &r);
        if (ret != ISC_R_SUCCESS)
                fatal("unknown class %s", str);
        return (rdclass);

diff --git a/bin/named/query.c b/bin/named/query.c
index c48f5c5aef9fa2455af5bd2069933044b0852ee9..c571b271c95650de1ba41cbf828c14d33afd4df3 100644 (file)
--- a/bin/named/query.c
+++ b/bin/named/query.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: query.c,v 1.252 2004/01/27 05:01:12 marka Exp $ */
+/* $Id: query.c,v 1.253 2004/02/03 00:59:03 marka Exp $ */
 
 #include <config.h>
 
@@ -3254,7 +3254,7 @@ query_find(ns_client_t *client, dns_fetchevent_t *event, dns_rdatatype_t qtype)
                dns_db_detach(&zdb);
        }
        if (event != NULL)
-               isc_event_free((isc_event_t **)(&event));
+               isc_event_free((isc_event_t **) (void*)&event);
 
        /*
         * AA bit.

diff --git a/bin/named/update.c b/bin/named/update.c
index 0c002884469544f2727cfbb027cb62f423cd9924..5f4a0bbf9c54a396aa4730e32f277d83e10632d2 100644 (file)
--- a/bin/named/update.c
+++ b/bin/named/update.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: update.c,v 1.106 2003/09/30 05:56:02 marka Exp $ */
+/* $Id: update.c,v 1.107 2004/02/03 00:59:03 marka Exp $ */
 
 #include <config.h>
 
@@ -1965,11 +1965,11 @@ send_update_event(ns_client_t *client, dns_zone_t *zone) {
        event->ev_arg = evclient;
 
        dns_zone_gettask(zone, &zonetask);
-       isc_task_send(zonetask, (isc_event_t **)&event);
+       isc_task_send(zonetask, (isc_event_t **) (void *)&event);
 
  failure:
        if (event != NULL)
-               isc_event_free((isc_event_t **)&event);
+               isc_event_free((isc_event_t **) (void *)&event);
        return (result);
 }
 
@@ -2702,7 +2702,7 @@ forward_fail(isc_task_t *task, isc_event_t *event) {
 
        respond(client, DNS_R_SERVFAIL);
        ns_client_detach(&client);
-       isc_event_free((isc_event_t **)&event);
+       isc_event_free(&event);
 }
 
 
@@ -2720,7 +2720,7 @@ forward_callback(void *arg, isc_result_t result, dns_message_t *answer) {
                uev->ev_action = forward_done;
                uev->answer = answer;
        }
-       isc_task_send(client->task, (isc_event_t**)&uev);
+       isc_task_send(client->task, (isc_event_t **) (void *)&uev);
 }
 
 static void
@@ -2732,7 +2732,7 @@ forward_done(isc_task_t *task, isc_event_t *event) {
 
        ns_client_sendraw(client, uev->answer);
        dns_message_destroy(&uev->answer);
-       isc_event_free((isc_event_t **)&event);
+       isc_event_free(&event);
        ns_client_detach(&client);
 }
 
@@ -2774,10 +2774,10 @@ send_forward_event(ns_client_t *client, dns_zone_t *zone) {
        event->ev_arg = evclient;
 
        dns_zone_gettask(zone, &zonetask);
-       isc_task_send(zonetask, (isc_event_t **)&event);
+       isc_task_send(zonetask, (isc_event_t **) (void *)&event);
 
  failure:
        if (event != NULL)
-               isc_event_free((isc_event_t **)&event);
+               isc_event_free((isc_event_t **) (void *)&event);
        return (result);
 }

diff --git a/bin/named/xfrout.c b/bin/named/xfrout.c
index 2f0b213c0d2586ae353aba5da6426ce3d5eb6c12..80272c71cea0a08ada6f6cacc27e499504b33223 100644 (file)
--- a/bin/named/xfrout.c
+++ b/bin/named/xfrout.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: xfrout.c,v 1.113 2003/04/22 04:08:54 marka Exp $ */
+/* $Id: xfrout.c,v 1.114 2004/02/03 00:59:03 marka Exp $ */
 
 #include <config.h>
 
@@ -413,7 +413,7 @@ ixfr_rrstream_create(isc_mem_t *mctx,
        return (ISC_R_SUCCESS);
 
  failure:
-       ixfr_rrstream_destroy((rrstream_t **) &s);
+       ixfr_rrstream_destroy((rrstream_t **) (void *)&s);
        return (result);
 }
 
@@ -500,7 +500,7 @@ axfr_rrstream_create(isc_mem_t *mctx, dns_db_t *db, dns_dbversion_t *ver,
        return (ISC_R_SUCCESS);
 
  failure:
-       axfr_rrstream_destroy((rrstream_t **) &s);
+       axfr_rrstream_destroy((rrstream_t **) (void *)&s);
        return (result);
 }
 
@@ -620,7 +620,7 @@ soa_rrstream_create(isc_mem_t *mctx, dns_db_t *db, dns_dbversion_t *ver,
        return (ISC_R_SUCCESS);
 
  failure:
-       soa_rrstream_destroy((rrstream_t **) &s);
+       soa_rrstream_destroy((rrstream_t **) (void *)&s);
        return (result);
 }
 

diff --git a/bin/tests/db/t_db.c b/bin/tests/db/t_db.c
index 18f22322be25c5b29c755be75eeea8e55a0733b7..7db00b72d703adb64dd72549f56039062e8f42ea 100644 (file)
--- a/bin/tests/db/t_db.c
+++ b/bin/tests/db/t_db.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: t_db.c,v 1.29 2001/08/08 22:54:30 gson Exp $ */
+/* $Id: t_db.c,v 1.30 2004/02/03 00:59:03 marka Exp $ */
 
 #include <config.h>
 
@@ -44,7 +44,7 @@ t_create(const char *db_type, const char *origin, const char *class,
        int                     len;
        isc_result_t            dns_result;
        dns_dbtype_t            dbtype;
-       isc_constregion_t       region;
+       isc_textregion_t        region;
        isc_buffer_t            origin_buffer;
        dns_fixedname_t         dns_origin;
        dns_rdataclass_t        rdataclass;
@@ -66,10 +66,9 @@ t_create(const char *db_type, const char *origin, const char *class,
                return(dns_result);
        }
 
-       region.base = class;
+       DE_CONST(class, region.base);
        region.length = strlen(class);
-       dns_result = dns_rdataclass_fromtext(&rdataclass,
-                                            (isc_textregion_t *)&region);
+       dns_result = dns_rdataclass_fromtext(&rdataclass, &region);
        if (dns_result != ISC_R_SUCCESS) {
                t_info("dns_rdataclass_fromtext failed %s\n",
                       dns_result_totext(dns_result));

diff --git a/lib/dns/dbtable.c b/lib/dns/dbtable.c
index 4aa750beed7fdd08f1c97eff432d914d733e0510..5070ab937b058f25fed130dede3a2acb94cbe4fc 100644 (file)
--- a/lib/dns/dbtable.c
+++ b/lib/dns/dbtable.c
@@ -16,7 +16,7 @@
  */
 
 /*
- * $Id: dbtable.c,v 1.26 2001/11/30 01:59:06 gson Exp $
+ * $Id: dbtable.c,v 1.27 2004/02/03 00:59:04 marka Exp $
  */
 
 /*
@@ -211,7 +211,7 @@ dns_dbtable_remove(dns_dbtable_t *dbtable, dns_db_t *db) {
        RWLOCK(&dbtable->tree_lock, isc_rwlocktype_write);
 
        result = dns_rbt_findname(dbtable->rbt, name, 0, NULL,
-                                 (void **)&stored_data);
+                                 (void **) (void *)&stored_data);
 
        if (result == ISC_R_SUCCESS) {
                INSIST(stored_data == db);
@@ -275,7 +275,7 @@ dns_dbtable_find(dns_dbtable_t *dbtable, dns_name_t *name,
        RWLOCK(&dbtable->tree_lock, isc_rwlocktype_read);
 
        result = dns_rbt_findname(dbtable->rbt, name, rbtoptions, NULL,
-                                 (void **)&stored_data);
+                                 (void **) (void *)&stored_data);
 
        if (result == ISC_R_SUCCESS || result == DNS_R_PARTIALMATCH)
                dns_db_attach(stored_data, dbp);

diff --git a/lib/dns/dispatch.c b/lib/dns/dispatch.c
index 03d8eb41d2a06f2e342d5a480b69f25d77065fca..848202a3130ec95e5bb716d2c5e2160311bebc64 100644 (file)
--- a/lib/dns/dispatch.c
+++ b/lib/dns/dispatch.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: dispatch.c,v 1.113 2003/07/25 02:22:24 marka Exp $ */
+/* $Id: dispatch.c,v 1.114 2004/02/03 00:59:04 marka Exp $ */
 
 #include <config.h>
 
@@ -672,7 +672,7 @@ udp_recv(isc_task_t *task, isc_event_t *ev_in) {
                            rev, rev->buffer.base, rev->buffer.length,
                            resp->task);
                resp->item_out = ISC_TRUE;
-               isc_task_send(resp->task, (isc_event_t **)&rev);
+               isc_task_send(resp->task, (isc_event_t **) (void *)&rev);
        }
 
        /*
@@ -856,7 +856,7 @@ tcp_recv(isc_task_t *task, isc_event_t *ev_in) {
                            rev, rev->buffer.base, rev->buffer.length,
                            resp->task);
                resp->item_out = ISC_TRUE;
-               isc_task_send(resp->task, (isc_event_t **)&rev);
+               isc_task_send(resp->task, (isc_event_t **) (void *)&rev);
        }
 
        /*
@@ -2078,7 +2078,7 @@ do_cancel(dns_dispatch_t *disp, dns_dispentry_t *resp) {
                    "cancel: failsafe event %p -> task %p",
                    ev, resp->task);
        resp->item_out = ISC_TRUE;
-       isc_task_send(resp->task, (isc_event_t **)&ev);
+       isc_task_send(resp->task, (isc_event_t **) (void *)&ev);
 }
 
 isc_socket_t *
@@ -2174,7 +2174,7 @@ dns_dispatch_importrecv(dns_dispatch_t *disp, isc_event_t *event) {
 
        buf = allocate_udp_buffer(disp);
        if (buf == NULL) {
-               isc_event_free((isc_event_t **)&newsevent);
+               isc_event_free((isc_event_t **) (void *)&newsevent);
                return;
        }
        memcpy(buf, sevent->region.base, sevent->n);
@@ -2187,7 +2187,7 @@ dns_dispatch_importrecv(dns_dispatch_t *disp, isc_event_t *event) {
        newsevent->pktinfo = sevent->pktinfo;
        newsevent->attributes = sevent->attributes;
        
-       isc_task_send(disp->task, (isc_event_t **)&newsevent);
+       isc_task_send(disp->task, (isc_event_t **) (void*)&newsevent);
 }
 
 #if 0

diff --git a/lib/dns/lookup.c b/lib/dns/lookup.c
index dbe984a994665e9172f27338d90524299afb05ad..21093a40941a5036803610f309b8e4f3759aa121 100644 (file)
--- a/lib/dns/lookup.c
+++ b/lib/dns/lookup.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: lookup.c,v 1.12 2003/10/25 00:31:09 jinmei Exp $ */
+/* $Id: lookup.c,v 1.13 2004/02/03 00:59:04 marka Exp $ */
 
 #include <config.h>
 
@@ -316,7 +316,7 @@ lookup_find(dns_lookup_t *lookup, dns_fetchevent_t *event) {
                                dns_db_detachnode(event->db, &event->node);
                        if (event->db != NULL)
                                dns_db_detach(&event->db);
-                       isc_event_free((isc_event_t **)&event);
+                       isc_event_free((isc_event_t **) (void *)&event);
                }
 
                /*

diff --git a/lib/dns/rbtdb.c b/lib/dns/rbtdb.c
index abd7f7c5afc1cd4978bf38818f1c11b54fbd9dd7..ec2d7e6545e2de1d34af5d4eb8f4dba9febdae8d 100644 (file)
--- a/lib/dns/rbtdb.c
+++ b/lib/dns/rbtdb.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: rbtdb.c,v 1.192 2004/01/14 02:06:50 marka Exp $ */
+/* $Id: rbtdb.c,v 1.193 2004/02/03 00:59:04 marka Exp $ */
 
 /*
  * Principal Author: Bob Halley
@@ -3356,7 +3356,7 @@ zone_findrdataset(dns_db_t *db, dns_dbnode_t *node, dns_dbversion_t *version,
        REQUIRE(type != dns_rdatatype_any);
 
        if (rbtversion == NULL) {
-               currentversion(db, (dns_dbversion_t **)(&rbtversion));
+               currentversion(db, (dns_dbversion_t **) (void *)(&rbtversion));
                close_version = ISC_TRUE;
        }
        serial = rbtversion->serial;
@@ -3414,7 +3414,8 @@ zone_findrdataset(dns_db_t *db, dns_dbnode_t *node, dns_dbversion_t *version,
        UNLOCK(&rbtdb->node_locks[rbtnode->locknum].lock);
 
        if (close_version)
-               closeversion(db, (dns_dbversion_t **)(&rbtversion), ISC_FALSE);
+               closeversion(db, (dns_dbversion_t **) (void *)(&rbtversion),
+                            ISC_FALSE);
 
        if (found == NULL)
                return (ISC_R_NOTFOUND);
@@ -3520,7 +3521,8 @@ allrdatasets(dns_db_t *db, dns_dbnode_t *node, dns_dbversion_t *version,
        if ((db->attributes & DNS_DBATTR_CACHE) == 0) {
                now = 0;
                if (rbtversion == NULL)
-                       currentversion(db, (dns_dbversion_t **)(&rbtversion));
+                       currentversion(db,
+                                (dns_dbversion_t **) (void *)(&rbtversion));
                else {
                        LOCK(&rbtdb->lock);
                        INSIST(rbtversion->references > 0);

diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c
index b828b51355d4167617229f74c421c8f8d1444fee..09e28fc65e6b7d3989c43b1b9face4e593c4160f 100644 (file)
--- a/lib/dns/resolver.c
+++ b/lib/dns/resolver.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: resolver.c,v 1.279 2004/02/02 04:37:39 marka Exp $ */
+/* $Id: resolver.c,v 1.280 2004/02/03 00:59:05 marka Exp $ */
 
 #include <config.h>
 
@@ -721,7 +721,7 @@ fctx_sendevents(fetchctx_t *fctx, isc_result_t result) {
                       fctx->type == dns_rdatatype_any ||
                       fctx->type == dns_rdatatype_rrsig);
 
-               isc_task_sendanddetach(&task, (isc_event_t **)&event);
+               isc_task_sendanddetach(&task, (isc_event_t **) (void *)&event);
        }
 }
 
@@ -5952,7 +5952,7 @@ dns_resolver_cancelfetch(dns_fetch_t *fetch) {
                etask = event->ev_sender;
                event->ev_sender = fctx;
                event->result = ISC_R_CANCELED;
-               isc_task_sendanddetach(&etask, (isc_event_t **)&event);
+               isc_task_sendanddetach(&etask, (isc_event_t **) (void *)&event);
        }
        /*
         * The fctx continues running even if no fetches remain;

diff --git a/lib/dns/sdb.c b/lib/dns/sdb.c
index 1bbdd94076695c3b793aa671fbcdc2fa96de4bbf..af33c3de4b46e49561104a816fe22203f7dc60cd 100644 (file)
--- a/lib/dns/sdb.c
+++ b/lib/dns/sdb.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: sdb.c,v 1.41 2004/01/14 02:06:50 marka Exp $ */
+/* $Id: sdb.c,v 1.42 2004/02/03 00:59:05 marka Exp $ */
 
 #include <config.h>
 
@@ -341,7 +341,7 @@ dns_sdb_putrr(dns_sdblookup_t *lookup, const char *type, dns_ttl_t ttl,
 {
        unsigned int datalen;
        dns_rdatatype_t typeval;
-       isc_consttextregion_t r;
+       isc_textregion_t r;
        isc_lex_t *lex = NULL;
        isc_result_t result;
        unsigned char *p = NULL;
@@ -358,9 +358,9 @@ dns_sdb_putrr(dns_sdblookup_t *lookup, const char *type, dns_ttl_t ttl,
 
        mctx = lookup->sdb->common.mctx;
 
-       r.base = type;
+       DE_CONST(type, r.base);
        r.length = strlen(type);
-       result = dns_rdatatype_fromtext(&typeval, (isc_textregion_t *)&r);
+       result = dns_rdatatype_fromtext(&typeval, &r);
        if (result != ISC_R_SUCCESS)
                return (result);
 
@@ -713,7 +713,7 @@ destroynode(dns_sdbnode_t *node) {
        DESTROYLOCK(&node->lock);
        node->magic = 0;
        isc_mem_put(mctx, node, sizeof(dns_sdbnode_t));
-       detach((dns_db_t **)&sdb);
+       detach((dns_db_t **) (void *)&sdb);
 }
 
 static isc_result_t
@@ -1054,7 +1054,7 @@ createiterator(dns_db_t *db, isc_boolean_t relative_names,
        result = imp->methods->allnodes(sdb->zone, sdb->dbdata, sdbiter);
        MAYBE_UNLOCK(sdb);
        if (result != ISC_R_SUCCESS) {
-               dbiterator_destroy((dns_dbiterator_t **)&sdbiter);
+               dbiterator_destroy((dns_dbiterator_t **) (void *)&sdbiter);
                return (result);
        }
 

diff --git a/lib/dns/validator.c b/lib/dns/validator.c
index aadb3eaf46e59ba0920f875c37f4f2e5b438901b..70e6fe79add832aa0cfc5eb7a21ed31bb006a21f 100644 (file)
--- a/lib/dns/validator.c
+++ b/lib/dns/validator.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: validator.c,v 1.116 2004/01/20 14:19:42 marka Exp $ */
+/* $Id: validator.c,v 1.117 2004/02/03 00:59:05 marka Exp $ */
 
 #include <config.h>
 
@@ -2043,7 +2043,7 @@ dns_validator_create(dns_view_t *view, dns_name_t *name, dns_rdatatype_t type,
        ISC_LINK_INIT(val, link);
        val->magic = VALIDATOR_MAGIC;
 
-       isc_task_send(task, (isc_event_t **)&event);
+       isc_task_send(task, (isc_event_t **) (void *)&event);
 
        *validatorp = val;
 

diff --git a/lib/dns/zt.c b/lib/dns/zt.c
index 00b66136b8e66fc5c1d7ba4802f744a7a14467f2..43bdf894daa46581df19c4bb393e4dfdc6e47660 100644 (file)
--- a/lib/dns/zt.c
+++ b/lib/dns/zt.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: zt.c,v 1.35 2002/09/10 02:23:45 marka Exp $ */
+/* $Id: zt.c,v 1.36 2004/02/03 00:59:05 marka Exp $ */
 
 #include <config.h>
 
@@ -148,7 +148,7 @@ dns_zt_find(dns_zt_t *zt, dns_name_t *name, unsigned int options,
        RWLOCK(&zt->rwlock, isc_rwlocktype_read);
 
        result = dns_rbt_findname(zt->table, name, rbtoptions, foundname,
-                                 (void **)&dummy);
+                                 (void **) (void*)&dummy);
        if (result == ISC_R_SUCCESS || result == DNS_R_PARTIALMATCH)
                dns_zone_attach(dummy, zonep);
 

diff --git a/lib/isc/unix/socket.c b/lib/isc/unix/socket.c
index ab57cb0cd9e95df663162584747cfa6b694120d9..82f592f83eed4e92aab52f21d7e8a2a0da8cc46f 100644 (file)
--- a/lib/isc/unix/socket.c
+++ b/lib/isc/unix/socket.c
@@ -15,7 +15,7 @@
  * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: socket.c,v 1.234 2004/01/29 04:39:19 marka Exp $ */
+/* $Id: socket.c,v 1.235 2004/02/03 00:59:05 marka Exp $ */
 
 #include <config.h>
 
@@ -1958,7 +1958,7 @@ internal_accept(isc_task_t *me, isc_event_t *ev) {
        task = dev->ev_sender;
        dev->ev_sender = sock;
 
-       isc_task_sendanddetach(&task, (isc_event_t **)&dev);
+       isc_task_sendanddetach(&task, (isc_event_t **) (void *)&dev);
        return;
 
  soft_error:
@@ -2997,7 +2997,7 @@ isc_socket_accept(isc_socket_t *sock,
 
        ret = allocate_socket(manager, sock->type, &nsock);
        if (ret != ISC_R_SUCCESS) {
-               isc_event_free((isc_event_t **)&dev);
+               isc_event_free((isc_event_t **) (void *)&dev);
                UNLOCK(&sock->lock);
                return (ret);
        }
@@ -3097,12 +3097,12 @@ isc_socket_connect(isc_socket_t *sock, isc_sockaddr_t *addr,
                UNEXPECTED_ERROR(__FILE__, __LINE__, "%d/%s", errno, strbuf);
 
                UNLOCK(&sock->lock);
-               isc_event_free((isc_event_t **)&dev);
+               isc_event_free((isc_event_t **) (void *)&dev);
                return (ISC_R_UNEXPECTED);
 
        err_exit:
                sock->connected = 0;
-               isc_task_send(task, (isc_event_t **)&dev);
+               isc_task_send(task, (isc_event_t **) (void *)&dev);
 
                UNLOCK(&sock->lock);
                return (ISC_R_SUCCESS);
@@ -3115,7 +3115,7 @@ isc_socket_connect(isc_socket_t *sock, isc_sockaddr_t *addr,
                sock->connected = 1;
                sock->bound = 1;
                dev->result = ISC_R_SUCCESS;
-               isc_task_send(task, (isc_event_t **)&dev);
+               isc_task_send(task, (isc_event_t **) (void *)&dev);
 
                UNLOCK(&sock->lock);
                return (ISC_R_SUCCESS);
@@ -3253,7 +3253,7 @@ internal_connect(isc_task_t *me, isc_event_t *ev) {
 
        task = dev->ev_sender;
        dev->ev_sender = sock;
-       isc_task_sendanddetach(&task, (isc_event_t **)&dev);
+       isc_task_sendanddetach(&task, (isc_event_t **) (void *)&dev);
 }
 
 isc_result_t
@@ -3401,7 +3401,7 @@ isc_socket_cancel(isc_socket_t *sock, isc_task_t *task, unsigned int how) {
                                dev->result = ISC_R_CANCELED;
                                dev->ev_sender = sock;
                                isc_task_sendanddetach(&current_task,
-                                                      (isc_event_t **)&dev);
+                                               (isc_event_t **) (void *)&dev);
                        }
 
                        dev = next;
@@ -3428,7 +3428,7 @@ isc_socket_cancel(isc_socket_t *sock, isc_task_t *task, unsigned int how) {
                        dev->result = ISC_R_CANCELED;
                        dev->ev_sender = sock;
                        isc_task_sendanddetach(&current_task,
-                                              (isc_event_t **)&dev);
+                                              (isc_event_t **) (void *)&dev);
                }
        }