gdb/testsuite: add testcase for .debug_gdb_scripts being compressed

This is a test-case to make sure that
8eb1701823e46179e3adcb49abf57126b3c49f28
("gdb: fix loading compressed scripts from `.debug_gdb_scripts`-section")
doesn't regress.

The test was mostly implemented by Tom Tromey, with the exception of the
check to make sure that the sections are actually compressed and
corrected compiler flags (-Wl,--compress-debug-sections=zlib-gabi was
missing).

This is an individual patch since the actual fix already landed in the
repository.

Approved-By: Tom Tromey <tom@tromey.com>

diff --git a/gdb/testsuite/gdb.python/py-section-script.exp b/gdb/testsuite/gdb.python/py-section-script.exp
index bf637284f0d92c1618d7f643b5b53d69f1e28276..f5f85b5202a79fffc08679fb71c1a24058bd5596 100644 (file)
--- a/gdb/testsuite/gdb.python/py-section-script.exp
+++ b/gdb/testsuite/gdb.python/py-section-script.exp
@@ -39,120 +39,138 @@ set remote_python_file [gdb_remote_download host \
 
 set quoted_name "\"$remote_python_file\""
 
-if {[build_executable $testfile.exp $testfile $srcfile \
-        [list debug \
-             additional_flags=-I${srcdir}/../../include \
-             additional_flags=-DSCRIPT_FILE=$quoted_name]] == -1} {
-    return -1
-}
-
-clean_restart
+foreach_with_prefix variant {plain compressed} {
+    set flags [list debug \
+                  additional_flags=-I${srcdir}/../../include \
+                  additional_flags=-DSCRIPT_FILE=$quoted_name]
+    if {$variant == "compressed"} {
+       lappend flags additional_flags=-Wa,--compress-debug-sections=zlib-gabi
+       lappend flags additional_flags=-Wl,--compress-debug-sections=zlib-gabi
+    }
 
-# Try first with a restrictive safe-path.
+    if {[build_executable $testfile.exp $testfile $srcfile $flags] == -1} {
+       return
+    }
 
-gdb_test_no_output "set auto-load safe-path /restricted" \
-    "set restricted auto-load safe-path"
-gdb_load ${binfile}
+    if {$variant == "compressed"} {
+       set objdump_program [gdb_find_objdump]
+       set debug_sect [exec $objdump_program -j .debug_gdb_scripts -s "$binfile"]
+       set debug_sect_decompressed [exec $objdump_program -j .debug_gdb_scripts \
+                           -s "$binfile" --decompress]
 
-# Verify gdb did not load the scripts.
-set test_name "verify scripts not loaded"
-gdb_test_multiple "info auto-load python-scripts" "$test_name" {
-    -re "Yes.*${testfile}.py.*Yes.*inlined-script.*$gdb_prompt $" {
-       fail "$test_name"
-    }
-    -re "No.*${testfile}.py.*No.*inlined-script.*$gdb_prompt $" {
-       pass "$test_name"
+       if {$debug_sect == $debug_sect_decompressed} {
+           fail ".debug_gdb_scripts in $binfile is not compressed"
+       }
     }
-}
 
-# Try again with a working safe-path.
+    clean_restart
 
-clean_restart
+    # Try first with a restrictive safe-path.
 
-# Get the name of the binfile on the host; on a remote host this means
-# stripping off any directory prefix.
-if {[is_remote host]} {
-    set remote_binfile [file tail ${binfile}]
-} else {
-    set remote_binfile ${binfile}
-}
+    gdb_test_no_output "set auto-load safe-path /restricted" \
+       "set restricted auto-load safe-path"
+    gdb_load ${binfile}
 
-if {[ishost *-*-mingw*]} {
-    set remote_pathsep ";"
-} else {
-    set remote_pathsep ":"
-}
-gdb_test_no_output "set auto-load safe-path ${remote_python_file}${remote_pathsep}${remote_binfile}" \
-    "set auto-load safe-path"
-gdb_load ${binfile}
-
-# Verify gdb loaded each script and they appear once in the list.
-set test_name "verify scripts loaded"
-gdb_test_multiple "info auto-load python-scripts" "$test_name" {
-    -re "Yes.*${testfile}.py.*Yes.*inlined-script.*$gdb_prompt $" {
-       pass "$test_name"
-    }
-    -re "${testfile}.py.*${testfile}.py.*$gdb_prompt $" {
-       fail "$test_name"
+    # Verify gdb did not load the scripts.
+    set test_name "verify scripts not loaded"
+    gdb_test_multiple "info auto-load python-scripts" "$test_name" {
+       -re "Yes.*${testfile}.py.*Yes.*inlined-script.*$gdb_prompt $" {
+           fail "$test_name"
+       }
+       -re "No.*${testfile}.py.*No.*inlined-script.*$gdb_prompt $" {
+           pass "$test_name"
+       }
     }
-    -re "inlined-script.*inlined-script.*$gdb_prompt $" {
-       fail "$test_name"
+
+    # Try again with a working safe-path.
+
+    clean_restart
+
+    # Get the name of the binfile on the host; on a remote host this means
+    # stripping off any directory prefix.
+    if {[is_remote host]} {
+       set remote_binfile [file tail ${binfile}]
+    } else {
+       set remote_binfile ${binfile}
     }
-}
 
-# Again, with a regexp this time.
-gdb_test "info auto-load python-scripts ${testfile}" "Yes.*${testfile}.py.*"
+    if {[ishost *-*-mingw*]} {
+       set remote_pathsep ";"
+    } else {
+       set remote_pathsep ":"
+    }
+    gdb_test_no_output "set auto-load safe-path ${remote_python_file}${remote_pathsep}${remote_binfile}" \
+       "set auto-load safe-path"
+    gdb_load ${binfile}
 
-# Again, with a regexp that matches no scripts.
-gdb_test "info auto-load python-scripts no-script-matches-this" \
-  "No auto-load scripts matching no-script-matches-this."
+    # Verify gdb loaded each script and they appear once in the list.
+    set test_name "verify scripts loaded"
+    gdb_test_multiple "info auto-load python-scripts" "$test_name" {
+       -re "Yes.*${testfile}.py.*Yes.*inlined-script.*$gdb_prompt $" {
+           pass "$test_name"
+       }
+       -re "${testfile}.py.*${testfile}.py.*$gdb_prompt $" {
+           fail "$test_name"
+       }
+       -re "inlined-script.*inlined-script.*$gdb_prompt $" {
+           fail "$test_name"
+       }
+    }
 
-if {![runto_main]} {
-    return
-}
+    # Again, with a regexp this time.
+    gdb_test "info auto-load python-scripts ${testfile}" "Yes.*${testfile}.py.*"
 
-gdb_test "b [gdb_get_line_number {break to inspect} ${testfile}.c ]" \
-    ".*Breakpoint.*"
-gdb_test "continue" ".*Breakpoint.*"
+    # Again, with a regexp that matches no scripts.
+    gdb_test "info auto-load python-scripts no-script-matches-this" \
+       "No auto-load scripts matching no-script-matches-this."
 
-gdb_test "print ss" " = a=<1> b=<2>"
+    if {![runto_main]} {
+       return
+    }
 
-gdb_test "test-cmd 1 2 3" "test-cmd output, arg = 1 2 3"
+    gdb_test "b [gdb_get_line_number {break to inspect} ${testfile}.c ]" \
+       ".*Breakpoint.*"
+    gdb_test "continue" ".*Breakpoint.*"
 
+    gdb_test "print ss" " = a=<1> b=<2>"
 
-# eu-strip creates NOBITS .debug_gdb_scripts sections in the debug files.
-# Make sure those are ignored silently.
+    gdb_test "test-cmd 1 2 3" "test-cmd output, arg = 1 2 3"
 
-with_test_prefix "sepdebug" {
-    gdb_exit
 
-    set result [catch {exec eu-strip -g -f ${binfile}.debug ${binfile}} output]
-    verbose "result is $result"
-    verbose "output is $output"
-    if {$result != 0 || $output != ""} {
-       unsupported "cannot produce separate debug info files"
-       return
-    }
+    # eu-strip creates NOBITS .debug_gdb_scripts sections in the debug files.
+    # Make sure those are ignored silently.
 
-    gdb_start
-    gdb_reinitialize_dir $srcdir/$subdir
+    with_test_prefix "sepdebug" {
+       gdb_exit
 
-    gdb_test_no_output "set auto-load safe-path ${remote_python_file}:${binfile}" \
-       "set auto-load safe-path"
-    set test "load sepdebug"
-    gdb_test_multiple "file $binfile" $test {
-       -re "\r\nwarning: Invalid entry in \\.debug_gdb_scripts section.*\r\n$gdb_prompt $" {
-           fail $test
+       set result [catch {exec eu-strip -g -f ${binfile}.debug ${binfile}} output]
+       verbose "result is $result"
+       verbose "output is $output"
+       if {$result != 0 || $output != ""} {
+           unsupported "cannot produce separate debug info files"
+           return
        }
-       -re "\r\n$gdb_prompt $" {
-           pass $test
+
+       gdb_start
+       gdb_reinitialize_dir $srcdir/$subdir
+
+       gdb_test_no_output "set auto-load safe-path ${remote_python_file}:${binfile}" \
+           "set auto-load safe-path"
+       set test "load sepdebug"
+       gdb_test_multiple "file $binfile" $test {
+           -re "\r\nwarning: Invalid entry in \\.debug_gdb_scripts section.*\r\n$gdb_prompt $" {
+               fail $test
+           }
+           -re "\r\n$gdb_prompt $" {
+               pass $test
+           }
        }
-    }
 
-    # Again, with a regexp this time.
-    gdb_test "info auto-load python-scripts ${testfile}" "Yes.*${testfile}.py.*"
+       # Again, with a regexp this time.
+       gdb_test "info auto-load python-scripts ${testfile}" "Yes.*${testfile}.py.*"
 
-    # Again, with a regexp that matches no scripts.
-    gdb_test "info auto-load python-scripts no-script-matches-this" \
-      "No auto-load scripts matching no-script-matches-this."
+       # Again, with a regexp that matches no scripts.
+       gdb_test "info auto-load python-scripts no-script-matches-this" \
+           "No auto-load scripts matching no-script-matches-this."
+    }
 }