]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: bm1880: add missing select GENERIC_PINCONF
authorBenjamin Boortz <bennib@mailbox.org>
Mon, 20 Jul 2026 17:51:04 +0000 (19:51 +0200)
committerLinus Walleij <linusw@kernel.org>
Sat, 25 Jul 2026 09:33:32 +0000 (11:33 +0200)
drivers/pinctrl/pinctrl-bm1880.c initialises its pinconf_ops with
.is_generic = true, but that field is only present when
CONFIG_GENERIC_PINCONF is enabled (guarded by #ifdef in pinconf.h).
The Kconfig entry for PINCTRL_BM1880 never selects GENERIC_PINCONF,
so any config that enables CONFIG_PINCTRL_BM1880=y without
CONFIG_GENERIC_PINCONF=y fails to compile:

  drivers/pinctrl/pinctrl-bm1880.c:1288:10: error: 'const struct pinconf_ops' has no member named 'is_generic'

Found by randconfig testing on arm64; tinyconfig reproducer below.
Add the missing select to fix the build.

Fixes: 49bd61ebce5f ("pinctrl: Add pinconf support for BM1880 SoC")
Cc: stable@vger.kernel.org
Signed-off-by: Benjamin Boortz <bennib@mailbox.org>
Signed-off-by: Linus Walleij <linusw@kernel.org>
drivers/pinctrl/Kconfig

index 23ea76dc6261a2c68daed5d261a754e7dac80570..eda54aa5fde6fc18962e7bca7e904cfc67c90c2f 100644 (file)
@@ -166,6 +166,7 @@ config PINCTRL_BM1880
        depends on OF && (ARCH_BITMAIN || COMPILE_TEST)
        default ARCH_BITMAIN
        select PINMUX
+       select GENERIC_PINCONF
        help
          Pinctrl driver for Bitmain BM1880 SoC.