]> git.ipfire.org Git - thirdparty/dracut-ng.git/commitdiff
fix(test-root): quote _terminfodir variable
authorBenjamin Drung <benjamin.drung@canonical.com>
Thu, 13 Jun 2024 23:40:32 +0000 (01:40 +0200)
committerLaszlo Gombos <laszlo.gombos@gmail.com>
Fri, 14 Jun 2024 18:04:19 +0000 (14:04 -0400)
shellcheck complains about SC2086 (info): Double quote to prevent
globbing and word splitting.

The variable `_terminfodir` refers to a path and therefore is safe to
be quoted.

Signed-off-by: Benjamin Drung <benjamin.drung@canonical.com>
modules.d/80test-root/module-setup.sh

index 64d618f146ee9c41a539b5ac19ffc28535c63216..c39111ceeb20281b0a7866d90fe7df7ec0137918 100755 (executable)
@@ -22,9 +22,9 @@ install() {
     inst_multiple mkdir ln dd stty mount poweroff umount setsid sync
 
     for _terminfodir in /lib/terminfo /etc/terminfo /usr/share/terminfo; do
-        [ -f ${_terminfodir}/l/linux ] && break
+        [ -f "${_terminfodir}/l/linux" ] && break
     done
-    inst_multiple -o ${_terminfodir}/l/linux
+    inst_multiple -o "${_terminfodir}/l/linux"
 
     inst_binary "${dracutbasedir}/dracut-util" "/usr/bin/dracut-util"
     ln -s dracut-util "${initdir}/usr/bin/dracut-getarg"