expr: masq: optional printing of flags attr in snprintf_default

The flags attribute is optional. Thus we should print only if it
was originally set.

Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/expr/masq.c b/src/expr/masq.c
index 6a1c609f63b63b78db0771e7c8f03d081575dc9a..b39a43a3c238c84e7df7edd35fa814419266501c 100644 (file)
--- a/src/expr/masq.c
+++ b/src/expr/masq.c
@@ -169,8 +169,10 @@ static int nft_rule_expr_masq_snprintf_default(char *buf, size_t len,
 {
        struct nft_expr_masq *masq = nft_expr_data(e);
 
-       return snprintf(buf, len, " flags %u ",
-                        masq->flags);
+       if (e->flags & (1 << NFT_EXPR_MASQ_FLAGS))
+               return snprintf(buf, len, "flags 0x%x ", masq->flags);
+
+       return 0;
 }
 
 static int nft_rule_expr_masq_snprintf(char *buf, size_t len, uint32_t type,