TCP: remove wrong INSIST(csock->recv_cb != NULL)

This commit removes wrong INSIST() condition as the assumption that if
'csock->recv_cb != NULL' iff 'csock->statichandle != NULL' is wrong.

There is no direct relation between 'csock->statichandle' and
'csock->recv_cb', as 'csock->statichandle' gets set when allocating a
handle regardless of 'csock->recv_cb' not being NULL, as it is
possible to attach to the handle without starting a read operation (at
the very least, it is correct to start writing before reading).

That condition made `cipher-suites` system test fail with crash on
some platforms in FIPS mode (namely, Oracle Linux 9) despite not being
related to FIPS at all.

diff --git a/lib/isc/netmgr/tcp.c b/lib/isc/netmgr/tcp.c
index 548f9bf65033bf9b8c8dca5ad1e6e664b7157a07..f7fe1a415b85b15a254b8339f2c34e0d21e9cbd5 100644 (file)
--- a/lib/isc/netmgr/tcp.c
+++ b/lib/isc/netmgr/tcp.c
@@ -914,10 +914,6 @@ accept_connection(isc_nmsocket_t *csock) {
         */
        isc_nmhandle_detach(&handle);
 
-       if (csock->statichandle != NULL) {
-               INSIST(csock->recv_cb != NULL);
-       }
-
        /*
         * sock is now attached to the handle.
         */