]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
nodeDeviceEventSubmit: Fix memory leak
authorPavel Hrdina <phrdina@redhat.com>
Tue, 7 Apr 2026 17:24:24 +0000 (19:24 +0200)
committerPavel Hrdina <phrdina@redhat.com>
Tue, 7 Apr 2026 18:55:32 +0000 (20:55 +0200)
In case driver is null we would leak memory allocated in event.

Fixes: b56458d443ba1d890d336535b5840252cbb9df4b
Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/node_device/node_device_udev.c

index 89aca2d4d623e110090dddcb9498d4c994fbf6fa..104433fb887a17dd101ad7d50c2ed2bdb7c9308f 100644 (file)
@@ -183,7 +183,7 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(nodeDeviceEvent, nodeDeviceEventFree);
   */
 static int nodeDeviceEventSubmit(nodeDeviceEventType eventType, void *data, virFreeCallback dataFreeFunc)
 {
-    nodeDeviceEvent *event = g_new0(nodeDeviceEvent, 1);
+    nodeDeviceEvent *event = NULL;
     udevEventData *priv = NULL;
 
     if (!driver)
@@ -191,6 +191,7 @@ static int nodeDeviceEventSubmit(nodeDeviceEventType eventType, void *data, virF
 
     priv = driver->privateData;
 
+    event = g_new0(nodeDeviceEvent, 1);
     event->eventType = eventType;
     event->data = data;
     event->dataFreeFunc = dataFreeFunc;