]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
mingw: Ensure symbols are quoted in Intel syntax
authorLIU Hao <lh_mouse@126.com>
Fri, 8 May 2026 13:02:23 +0000 (21:02 +0800)
committerJonathan Yong <10walls@gmail.com>
Mon, 11 May 2026 11:33:46 +0000 (11:33 +0000)
Previously, this code

   extern int shl;
   int get_shl(void) { return shl; }

gave errors like

   $ x86_64-w64-mingw32-gcc -masm=intel test.c
   ccUSyr0f.s: Assembler messages:
   ccUSyr0f.s:24: Error: invalid use of operator "shl"

because it contained

   .refptr.shl:
       .quad   shl

This `shl` should have referenced the symbol, but it appeared in an expression
context, where, in Intel syntax, it got interpreted as the shift-left operator.

This commit fixes the issue by emitting the target symbol with
`ASM_OUTPUT_LABELREF`, which will quote it properly with regard to the output
assembler syntax.

PR target/53929

gcc/ChangeLog:

* config/mingw/winnt.cc (mingw_pe_file_end): Use `ASM_OUTPUT_LABELREF`
to emit `name`.

Signed-off-by: LIU Hao <lh_mouse@126.com>
Signed-off-by: Jonathan Yong <10walls@gmail.com>
gcc/config/mingw/winnt.cc

index e926b25cf98a21b8efade491c4866304cfda5950..c73aa15ad37ece6b49d8f8ef0e70b8b5e77dd317 100644 (file)
@@ -860,7 +860,9 @@ mingw_pe_file_end (void)
                           "\t.p2align\t3, 0\n"
                           "\t.globl\t%s\n"
                           "\t.linkonce\tdiscard\n", oname, oname);
-         fprintf (asm_out_file, "%s:\n\t.quad\t%s\n", oname, name);
+         fprintf (asm_out_file, "%s:\n\t.quad\t", oname);
+         ASM_OUTPUT_LABELREF (asm_out_file, name);
+         fputc ('\n', asm_out_file);
        }
     }
 }