4882. [bug] Address potential memory leak in

                        dns_update_signaturesinc. [RT #47084]

(cherry picked from commit 7817caa3c77e384e748e8ae9cfa8ea95a6872b46)

diff --git a/CHANGES b/CHANGES
index dc71a5daa40692b87e744ab7b9c42cc314bb6a06..153087e6752eba7179b60fff6a24aaaa1fed74de 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+4882.  [bug]           Address potential memory leak in
+                       dns_update_signaturesinc. [RT #47084]
+
 4879.  [bug]           dns_rdata_caa:value_len is was small. [RT #47086]
 
 4878.  [bug]           List 'ply' as a requirement for the 'isc' python

diff --git a/lib/dns/update.c b/lib/dns/update.c
index 2c266f816cf1fbe52d46d193ee0a2dabf14943dd..506b1d1703dbae51100cc33c6b69cfded81397b9 100644 (file)
--- a/lib/dns/update.c
+++ b/lib/dns/update.c
@@ -2014,6 +2014,10 @@ dns_update_signaturesinc(dns_update_log_t *log, dns_zone_t *zone, dns_db_t *db,
        }
 
  failure:
+       if (node != NULL) {
+               dns_db_detachnode(db, &node);
+       }
+
        dns_diff_clear(&state->sig_diff);
        dns_diff_clear(&state->nsec_diff);
        dns_diff_clear(&state->nsec_mindiff);