drm/ast: Use constants for AHBC registers

AHBC is the Advanced High-Speed Bus Controller. AHBC registers are
located in the memory range within [0x1e600000, 0x1e61ffff]. Refer
to them with constants named AST_REG_AHBC<n>, where <n> is the byte
offset into the range.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://patch.msgid.link/20260327133532.79696-4-tzimmermann@suse.de

diff --git a/drivers/gpu/drm/ast/ast_2500.c b/drivers/gpu/drm/ast/ast_2500.c
index 2a52af0ded56ce9864fd733717dffd2ff6d08729..f751a27e7eb307485eb8b07ed986ee62ed39f378 100644 (file)
--- a/drivers/gpu/drm/ast/ast_2500.c
+++ b/drivers/gpu/drm/ast/ast_2500.c
@@ -109,9 +109,9 @@ void ast_2500_patch_ahb(void __iomem *regs)
        u32 data;
 
        /* Clear bus lock condition */
-       __ast_moutdwm(regs, 0x1e600000, 0xAEED1A03);
-       __ast_moutdwm(regs, 0x1e600084, 0x00010000);
-       __ast_moutdwm(regs, 0x1e600088, 0x00000000);
+       __ast_moutdwm(regs, AST_REG_AHBC00, AST_REG_AHBC00_PROTECT_KEY);
+       __ast_moutdwm(regs, AST_REG_AHBC84, 0x00010000);
+       __ast_moutdwm(regs, AST_REG_AHBC88, 0x00000000);
        __ast_moutdwm(regs, 0x1e6e2000, 0x1688A8A8);
 
        data = __ast_mindwm(regs, 0x1e6e2070);

diff --git a/drivers/gpu/drm/ast/ast_reg.h b/drivers/gpu/drm/ast/ast_reg.h
index ca9403efc7f9125fe0ecacaecc1ecb082c95e7ab..0bc033dbac556e66e3917ed3f71a23819735fa15 100644 (file)
--- a/drivers/gpu/drm/ast/ast_reg.h
+++ b/drivers/gpu/drm/ast/ast_reg.h
@@ -87,4 +87,15 @@
 #define AST_REG_P2A04                          AST_REG_P2A(0xf004)
 #define AST_REG_P2A04_BASE_MASK                        GENMASK(31, 16)
 
+/*
+ * AHB Controller (0x1e600000 - 0x1e61ffff)
+ */
+
+#define AST_REG_AHBC_BASE                      (0x1e600000)
+#define AST_REG_AHBC(__offset)                 (AST_REG_AHBC_BASE + (__offset))
+#define AST_REG_AHBC00                         AST_REG_AHBC(0x00)
+#define AST_REG_AHBC00_PROTECT_KEY             (0xaeed1a03)
+#define AST_REG_AHBC84                         AST_REG_AHBC(0x84)
+#define AST_REG_AHBC88                         AST_REG_AHBC(0x88)
+
 #endif