GDB: testsuite: server: Don't return value from top-level (manual)

This patch manually changes "return -1" statements that weren't caught
by the sed command.

These return statements return at top level but inside block such as
save_vars and with_test_prefix.

I also fixed one case of top-level "return 0".

Approved-By: Tom Tromey <tom@tromey.com>

diff --git a/gdb/testsuite/gdb.server/abspath.exp b/gdb/testsuite/gdb.server/abspath.exp
index 5bd7f7e842bb76c1337f695b61f4c0999dd6005d..7c4d43ff474dc0597e827e8f3e3f6aa725866715 100644 (file)
--- a/gdb/testsuite/gdb.server/abspath.exp
+++ b/gdb/testsuite/gdb.server/abspath.exp
@@ -38,7 +38,7 @@ save_vars { GDBFLAGS } {
     }
 
     if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.server/exit-multiple-threads.exp b/gdb/testsuite/gdb.server/exit-multiple-threads.exp
index 1b0941eb3c78a41a8569bc6f68728d25434897a5..c6e19f8dfb44040f894a04d673113618aee2f214 100644 (file)
--- a/gdb/testsuite/gdb.server/exit-multiple-threads.exp
+++ b/gdb/testsuite/gdb.server/exit-multiple-threads.exp
@@ -140,7 +140,7 @@ foreach_with_prefix test { exit signal } {
     set executable "$binfile-${test}"
     if {[build_executable "failed to prepare" $executable $srcfile \
             [list debug pthreads additional_flags=-D${def}]]} {
-       return -1
+       return
     }
 
     set target_executable [gdb_remote_download target $executable]

diff --git a/gdb/testsuite/gdb.server/ext-restart.exp b/gdb/testsuite/gdb.server/ext-restart.exp
index 39d42d7a4416b173625548a4ca01ef7fc8f4a9c3..031aaeb5db85f9dd3d6b440b2290fa6e94cfb238 100644 (file)
--- a/gdb/testsuite/gdb.server/ext-restart.exp
+++ b/gdb/testsuite/gdb.server/ext-restart.exp
@@ -31,7 +31,7 @@ save_vars { GDBFLAGS } {
     }
 
     if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.server/ext-wrapper.exp b/gdb/testsuite/gdb.server/ext-wrapper.exp
index 912a8ce377083b964ec2f82806a2fa92426f6117..757127b15488bcc4e75f62af45409ac5dc46baab 100644 (file)
--- a/gdb/testsuite/gdb.server/ext-wrapper.exp
+++ b/gdb/testsuite/gdb.server/ext-wrapper.exp
@@ -33,7 +33,7 @@ save_vars { GDBFLAGS } {
     }
 
     if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.server/extended-remote-restart.exp b/gdb/testsuite/gdb.server/extended-remote-restart.exp
index f10d2f374c09644c2ab1428e420d2d0a04b981cb..a592dba79ed51c07bf1a50f1e2337001a93a1ed3 100644 (file)
--- a/gdb/testsuite/gdb.server/extended-remote-restart.exp
+++ b/gdb/testsuite/gdb.server/extended-remote-restart.exp
@@ -42,7 +42,7 @@ require {is_any_target "*-*-linux*" "*-*-openbsd*"}
 set gdbserver_reconnect_p 1
 if { [info proc gdb_reconnect] == "" } {
     unsupported "requires gdbserver reconnect"
-    return 0
+    return
 }
 
 standard_testfile

diff --git a/gdb/testsuite/gdb.server/multi-ui-errors.exp b/gdb/testsuite/gdb.server/multi-ui-errors.exp
index c17de8bf2e481041b42f56540dd42718cce41dbe..dde936c1a45574387a07432824c0bb2721b43bc5 100644 (file)
--- a/gdb/testsuite/gdb.server/multi-ui-errors.exp
+++ b/gdb/testsuite/gdb.server/multi-ui-errors.exp
@@ -37,7 +37,7 @@ save_vars { GDBFLAGS } {
     }
 
     if {[prepare_for_testing "failed to prepare" ${testfile} ${srcfile}]} {
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
index 63502887bf555b1a502d9341a9ba88ac8b31f786..c0e129db76d52fc7123b4a381961b70e7582cc00 100644 (file)
--- a/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
+++ b/gdb/testsuite/gdb.server/reconnect-ctrl-c.exp
@@ -33,7 +33,7 @@ save_vars { GDBFLAGS } {
     }
 
     if {[prepare_for_testing "failed to prepare" $testfile $srcfile]} {
-       return -1
+       return
     }
 }
 

diff --git a/gdb/testsuite/gdb.server/wrapper.exp b/gdb/testsuite/gdb.server/wrapper.exp
index 15643fb92a7ca1900918dcb2b47cbf7a4f94dfd8..40c29c441fab39d0bdbc0e30731dde195c5774ca 100644 (file)
--- a/gdb/testsuite/gdb.server/wrapper.exp
+++ b/gdb/testsuite/gdb.server/wrapper.exp
@@ -37,7 +37,7 @@ save_vars { GDBFLAGS } {
     }
 
     if { [prepare_for_testing "failed to prepare" $testfile $srcfile debug] } {
-       return -1
+       return
     }
 }