]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
irqchip/gic-v4: Don't advertise VLPIs if no ITS is probed
authorMostafa Saleh <smostafa@google.com>
Tue, 26 May 2026 12:53:17 +0000 (12:53 +0000)
committerThomas Gleixner <tglx@kernel.org>
Tue, 26 May 2026 20:17:28 +0000 (22:17 +0200)
When accidentally setting “kvm-arm.vgic_v4_enable=1” on a system that has
no MSI controller device tree node and GICv4, it results a panic as
“gic_domain” is NULL and the kernel attempts to access it.

    Unable to handle kernel NULL pointer dereference at virtual address 0000000000000028
    Mem abort info:
      ESR = 0x0000000096000006

    CPU: 1 UID: 0 PID: 295 Comm: lkvm-static Not tainted 7.1.0-rc4-ge3f15ad3970e #5 PREEMPT
    Hardware name: linux,dummy-virt (DT)
    pstate: 81402005 (Nzcv daif +PAN -UAO -TCO +DIT -SSBS BTYPE=--)
    pc : __irq_domain_instantiate+0x1d4/0x578
    lr : __irq_domain_instantiate+0x1cc/0x578

Set vLPI support to false at init time if the host has no ITS, so it
propagates properly to kvm_vgic_global_state.has_gicv4.

Suggested-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Mostafa Saleh <smostafa@google.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://patch.msgid.link/20260526125317.3672297-1-smostafa@google.com
drivers/irqchip/irq-gic-v3-its.c

index e78795b7acfd64de8950d75ca44116fffb0b3af6..b57d81ad33a0a5f60caa0b8a501d8cb0704c719b 100644 (file)
@@ -5833,6 +5833,7 @@ int __init its_init(struct fwnode_handle *handle, struct rdists *rdists,
                its_acpi_probe();
 
        if (list_empty(&its_nodes)) {
+               rdists->has_vlpis = false;
                pr_warn("ITS: No ITS available, not enabling LPIs\n");
                return -ENXIO;
        }