[#3991] Fixed CWE 398 2 dangerousTypeCast

diff --git a/src/hooks/dhcp/ping_check/icmp_msg.cc b/src/hooks/dhcp/ping_check/icmp_msg.cc
index 3d236820daa1c6e58ea101336640a81815a079a8..22ef10b48b189e244c962435ed9b399413e5d23d 100644 (file)
--- a/src/hooks/dhcp/ping_check/icmp_msg.cc
+++ b/src/hooks/dhcp/ping_check/icmp_msg.cc
@@ -36,7 +36,7 @@ ICMPMsg::unpack(const uint8_t* wire_data, size_t length) {
     }
 
     // Find the IP header length...
-    struct ip* ip_header = (struct ip*)(wire_data);
+    struct ip const* ip_header = reinterpret_cast<struct ip const*>(wire_data);
     auto hlen = (ip_header->ip_hl << 2);
 
     // Make sure we received enough data.

diff --git a/src/lib/testutils/unix_control_client.cc b/src/lib/testutils/unix_control_client.cc
index f561115a04d0dfe6022fb06c13bfe8a65080b45f..503fc9f234b36ed1b62a30014170af4bad5d6216 100644 (file)
--- a/src/lib/testutils/unix_control_client.cc
+++ b/src/lib/testutils/unix_control_client.cc
@@ -61,7 +61,7 @@ bool UnixControlClient::connectToServer(const std::string& socket_path) {
     socklen_t len = sizeof(srv_addr);
 
     // Connect to the specified UNIX socket
-    int status = connect(socket_fd_, (struct sockaddr*)&srv_addr, len);
+    int status = connect(socket_fd_, reinterpret_cast<struct sockaddr*>(&srv_addr), len);
     if (status == -1) {
         const char* errmsg = strerror(errno);
         ADD_FAILURE() << "Failed to connect unix socket: fd=" << socket_fd_