2478. [bug] 'addresses' could be used uninitalized in

                        configure_forward(). [RT 18800]

diff --git a/CHANGES b/CHANGES
index 42e5dcbdc53aa28ad730e9355ed5dbeafe5c9e4d..86846c7ea8460cdde2e913609bbddf50631a4c04 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -3,6 +3,9 @@
                        warning or crash named with the debug 1 level
                        of logging. [RT #18917]
 
+2478.  [bug]           'addresses' could be used uninitalized in
+                       configure_forward(). [RT 18800]
+       
        --- 9.4.3 released ---
 
 2490.  [port]          aix: work around a kernel bug where IPV6_RECVPKTINFO

diff --git a/bin/named/server.c b/bin/named/server.c
index 784ff94d34143589a360ecbc301683b4366a60d5..3bb2b7baff95a856d83faa9730a32df02926a576 100644 (file)
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -15,7 +15,7 @@
  * PERFORMANCE OF THIS SOFTWARE.
  */
 
-/* $Id: server.c,v 1.419.18.68 2008/09/04 23:46:08 tbox Exp $ */
+/* $Id: server.c,v 1.419.18.69 2008/11/20 00:50:57 marka Exp $ */
 
 /*! \file */
 
@@ -1959,6 +1959,8 @@ configure_forward(const cfg_obj_t *config, dns_view_t *view, dns_name_t *origin,
        isc_result_t result;
        in_port_t port;
 
+       ISC_LIST_INIT(addresses);
+
        /*
         * Determine which port to send forwarded requests to.
         */
@@ -1984,8 +1986,6 @@ configure_forward(const cfg_obj_t *config, dns_view_t *view, dns_name_t *origin,
        if (forwarders != NULL)
                faddresses = cfg_tuple_get(forwarders, "addresses");
 
-       ISC_LIST_INIT(addresses);
-
        for (element = cfg_list_first(faddresses);
             element != NULL;
             element = cfg_list_next(element))