[Bug 202] faxrm & faxalter format string vulnerabilities

Collaborative effort to squash these, led by Lee. Thanks everyone!
This is a preliminary commit, which should be sanity-checked by anyone who
has a second, since we'd like to urge people to deploy 4.1.3 as a security
update

diff --git a/faxalter/faxalter.c++ b/faxalter/faxalter.c++
index 74c6ceffb201ba6613dfa67ad479cea5ab20fec4..eb6e4dad3368620c62392aa5d744bd913a3d3783 100644 (file)
--- a/faxalter/faxalter.c++
+++ b/faxalter/faxalter.c++
@@ -184,7 +184,7 @@ faxAlterApp::run(int argc, char** argv)
        hangupServer();
     }
     if (emsg != "")
-       printError(emsg);
+       printError("%s", (const char*) emsg);
 }
 
 void

diff --git a/faxrm/faxrm.c++ b/faxrm/faxrm.c++
index 47c79770495f4f55c5d580c5a0599c44236c3a46..cdfb97d59e085eb17c0eae86fcb187a5963cda07 100644 (file)
--- a/faxrm/faxrm.c++
+++ b/faxrm/faxrm.c++
@@ -100,7 +100,7 @@ faxRmApp::run(int argc, char** argv)
        hangupServer();
     }
     if (emsg != "")
-       printError(emsg);
+       printError("%s", (const char*) emsg);
 }
 
 bool

diff --git a/faxstat/faxstat.c++ b/faxstat/faxstat.c++
index b8563526daf48e07b6766ba4757a4d73331e18f1..9b8df52cefad7e729a859c80e36a05e88013182a 100644 (file)
--- a/faxstat/faxstat.c++
+++ b/faxstat/faxstat.c++
@@ -119,7 +119,7 @@ faxStatApp::run(int argc, char** argv)
        hangupServer();
     }
     if (emsg != "")
-       printError(emsg);
+       printError("%s", (const char*) emsg);
 }
 
 bool

diff --git a/sendfax/sendfax.c++ b/sendfax/sendfax.c++
index c611e414fde37668797fb535296eac52085e9d99..2ba6cea64cc224bba5940651d9806f1652d303a3 100644 (file)
--- a/sendfax/sendfax.c++
+++ b/sendfax/sendfax.c++
@@ -242,7 +242,7 @@ sendFaxApp::run(int argc, char** argv)
         }
         hangupServer();
     }
-    if (!status) printError(emsg);
+    if (!status) printError("%s", (const char*) emsg);
     return (status);
 }
 

diff --git a/sendpage/sendpage.c++ b/sendpage/sendpage.c++
index 9773eea029b34da4d7d0118a3588188078225c64..c7dfb0e947779c16b878991a49b722ee0af73656 100644 (file)
--- a/sendpage/sendpage.c++
+++ b/sendpage/sendpage.c++
@@ -166,7 +166,7 @@ sendPageApp::run(int argc, char** argv)
        hangupServer();
     }
     if (!status)
-       printError(emsg);
+       printError("%s", (const char*) emsg);
     return (status);
 }
 

diff --git a/util/faxfetch.c++ b/util/faxfetch.c++
index 4e9934b90e5d1c238340fed2ae4d746b24389e22..ee761aa4161cbf26444be79ce029ff4b84997fbf 100644 (file)
--- a/util/faxfetch.c++
+++ b/util/faxfetch.c++
@@ -99,7 +99,7 @@ faxFetchApp::run(int argc, char** argv)
            hangupServer();
        }
        if (emsg != "")
-           printError(emsg);
+           printError("%s", (const char*) emsg);
     }
 }
 

diff --git a/util/faxwatch.c++ b/util/faxwatch.c++
index ca789edf5bd88ce8108e660dcd8ee74a7d5dca27..f1f9984e9e05e7a66797e21aef2dda77e5572a6d 100644 (file)
--- a/util/faxwatch.c++
+++ b/util/faxwatch.c++
@@ -102,7 +102,7 @@ watchApp::run(int argc, char** argv)
        hangupServer();
     }
     if (emsg != "")
-       printError(emsg);
+       printError("%s", (const char*) emsg);
 }
 
 void