dns_rdata_tostruct() should reject rdata with DNS_RDATA_UPDATE set

diff --git a/lib/dns/include/dns/rdata.h b/lib/dns/include/dns/rdata.h
index 9221c8951add809e172972f02c19f829adf56548..359f69d674cca2ed0b50a4136688fc073f454e43 100644 (file)
--- a/lib/dns/include/dns/rdata.h
+++ b/lib/dns/include/dns/rdata.h
@@ -516,7 +516,7 @@ dns_rdata_tostruct(const dns_rdata_t *rdata, void *target, isc_mem_t *mctx);
  *
  * Requires:
  *
- *\li  'rdata' is a valid, non-empty rdata.
+ *\li  'rdata' is a valid, non-empty, non-pseudo rdata.
  *
  *\li  'target' to point to a valid pointer for the type and class.
  *

diff --git a/lib/dns/rdata.c b/lib/dns/rdata.c
index a2eb404f411c485b9fbc203a1437063b3f66baac..6fb7bc3d22860abbdb72b79ec8aaea4be3be5395 100644 (file)
--- a/lib/dns/rdata.c
+++ b/lib/dns/rdata.c
@@ -1222,6 +1222,7 @@ dns_rdata_tostruct(const dns_rdata_t *rdata, void *target, isc_mem_t *mctx) {
 
        REQUIRE(rdata != NULL);
        REQUIRE(DNS_RDATA_VALIDFLAGS(rdata));
+       REQUIRE((rdata->flags & DNS_RDATA_UPDATE) == 0);
 
        TOSTRUCTSWITCH