]> git.ipfire.org Git - thirdparty/openldap.git/commitdiff
request_abandon RFC4511 conformance
authorOndřej Kuzník <ondra@mistotebe.net>
Wed, 13 Dec 2017 12:17:23 +0000 (12:17 +0000)
committerOndřej Kuzník <okuznik@symas.com>
Tue, 17 Nov 2020 17:58:14 +0000 (17:58 +0000)
servers/lloadd/client.c

index fb91cde901d30b0216a988d1bb0f898bc762a7c2..43dcfed82252dc1710f3cdef7a440394828c84eb 100644 (file)
@@ -39,10 +39,8 @@ request_abandon( Connection *c, Operation *op )
                 "connid=%lu msgid=%d invalid integer sent in abandon request\n",
                 c->c_connid, op->o_client_msgid );
 
-        if ( operation_send_reject_locked( op, LDAP_PROTOCOL_ERROR,
-                     "invalid PDU received", 0 ) == LDAP_SUCCESS ) {
-            CONNECTION_DESTROY(c);
-        }
+        operation_destroy_from_client( op );
+        CONNECTION_DESTROY(c);
         return -1;
     }
 
@@ -221,8 +219,8 @@ handle_one_request( Connection *c )
             handler = request_bind;
             break;
         case LDAP_REQ_ABANDON:
-            /* FIXME: We need to be able to abandon a Bind request, handling
-             * ExOps (esp. Cancel) will be different */
+            /* We can't send a response to abandon requests even if a bind is
+             * currently in progress */
             handler = request_abandon;
             break;
         case LDAP_REQ_EXTENDED: