BUG/MINOR: tools: free previously allocated strings on strdup failure in backup_env()

When strdup() fails after some entries have already been strdup'd, the function
returned -1 without freeing previously allocated strings. Added cleanup loop to
free all previously strdup'd entries and reset init_env.

This can be backported to 3.1.

diff --git a/src/tools.c b/src/tools.c
index cdd9cbe5fcb8c1dbaf1c43bef4cd69dbbb76f051..741622fa65916723b022f61bb5616a984173e6f0 100644 (file)
--- a/src/tools.c
+++ b/src/tools.c
@@ -7562,6 +7562,13 @@ int backup_env(void)
                if (*tmp == NULL) {
                        ha_alert("Cannot allocate memory to backup env variable '%s'.\n",
                                 *env);
+                       tmp = init_env;
+                       while (*tmp) {
+                               free(*tmp);
+                               tmp++;
+                       }
+                       free(init_env);
+                       init_env = NULL;
                        return -1;
                }
                tmp++;