]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Fix leak in checkds code
authorMatthijs Mekking <matthijs@isc.org>
Mon, 12 Jul 2021 08:10:12 +0000 (10:10 +0200)
committerMatthijs Mekking <matthijs@isc.org>
Tue, 13 Jul 2021 09:20:24 +0000 (11:20 +0200)
In 'checkds_send_toaddr' there is a goto bug that causes the TSIG key
and DNS message to not be detached. Remove the offending goto statement.

(cherry picked from commit b67616393398a107f0d359cce225b64bda3979b3)

lib/dns/zone.c

index f19c508782c890e61268ba79de85cb579c73ca58..12021e473d61f972796ce2055be5892b4065a4a5 100644 (file)
@@ -21040,7 +21040,6 @@ checkds_send_toaddr(isc_task_t *task, isc_event_t *event) {
                        checkds->zone, ISC_LOG_DEBUG(3),
                        "checkds: dns_request_createvia() to %s failed: %s",
                        addrbuf, dns_result_totext(result));
-               goto cleanup;
        }
 
 cleanup_key: